Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Fastify #384

Closed
Sharlaan opened this issue Jul 1, 2018 · 9 comments
Closed

Support for Fastify #384

Sharlaan opened this issue Jul 1, 2018 · 9 comments

Comments

@Sharlaan
Copy link

Sharlaan commented Jul 1, 2018

I just discovered GQL-Yoga, and it really is impressive and clean, great work ! 馃憦

I'm just wondering (besides updating to apollo-server v2+ which is already covered in another issue) how complicated it would be to migrate Express to a faster alternative, ie Fastify ?

@cpenarrieta
Copy link

@Sharlaan this will require first apollo-server to support fastify. see apollographql/apollo-server#659 and apollographql/apollo-server#626
Later, graphql-yoga will need to support different servers other than express only (based on apollo server integrations https://github.com/apollographql/apollo-server/tree/master/packages).

@stale
Copy link

stale bot commented Nov 23, 2018

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 23, 2018
@Sharlaan
Copy link
Author

Sharlaan commented Nov 23, 2018

It is far from inactive, @addityasingh has been very active at integrating fastify into apollo-server
feat(fastify): Integrate apollo-fastify plugin [WIP]

@stale stale bot removed the stale label Nov 23, 2018
@poupryc
Copy link

poupryc commented Jan 18, 2019

I see that apollographql/apollo-server#626 was closed. What the status of this issue please ?

@Sharlaan
Copy link
Author

it is still referencing another thread whose last commit is 16 days ago

@stale
Copy link

stale bot commented Mar 19, 2019

Due to inactivity of this issue we have marked it stale. It will be closed if no further activity occurs.

@stale stale bot added the status/stale label Mar 19, 2019
@stale
Copy link

stale bot commented Apr 1, 2019

Hey 馃憢, It seems like this issue has been inactive for some time. In need for maintaining clear overview of the issues concerning the latest version of graphql-yoga we'll close it.
Feel free to reopen it at any time if you believe we should futher discuss its content. 馃檪

@stale stale bot closed this as completed Apr 1, 2019
@karlos1337
Copy link

Apollo-server have already a working Fastify integration https://github.com/apollographql/apollo-server/tree/master/packages/apollo-server-fastify

@blacksmoke26
Copy link

Apollo-server have already a working Fastify integration https://github.com/apollographql/apollo-server/tree/master/packages/apollo-server-fastify

Is it stable? Production-ready or still premature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants