Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dotnet tool should embed a NOTICE.txt file #2557

Open
sebastienros opened this issue Oct 16, 2023 · 3 comments
Open

The dotnet tool should embed a NOTICE.txt file #2557

sebastienros opened this issue Oct 16, 2023 · 3 comments

Comments

@sebastienros
Copy link
Member

Because the dotnet tool ships the binaries of 3rd party dependencies it should include a NOTICE file listing these and their licenses. This is not required for the NuGet packages as they only "reference" other libraries, but it is for dotnet tools. I found these dependencies at least: NewtonSoft.Json, Humanizer.

@deepchoudhery
Copy link
Contributor

Yes will take a look at this soon tyty

@deepchoudhery
Copy link
Contributor

Because the dotnet tool ships the binaries of 3rd party dependencies it should include a NOTICE file listing these and their licenses. This is not required for the NuGet packages as they only "reference" other libraries, but it is for dotnet tools. I found these dependencies at least: NewtonSoft.Json, Humanizer.

is there a template I should be following for dotnet repos?

@sebastienros
Copy link
Member Author

Here is one you could use:
https://github.com/dotnet/crank/blob/main/NOTICE.txt

aspnet and runtime are both like this one:
https://github.com/dotnet/aspnetcore/blob/main/THIRD-PARTY-NOTICES.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants