Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support google.type.Decimal in gRPC JSON transcoding #51520

Closed
1 task done
alrz opened this issue Oct 20, 2023 · 2 comments
Closed
1 task done

Support google.type.Decimal in gRPC JSON transcoding #51520

alrz opened this issue Oct 20, 2023 · 2 comments
Labels
area-grpc Includes: GRPC wire-up, templates

Comments

@alrz
Copy link
Contributor

alrz commented Oct 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

Technically this type is not a wrapper type and it's not implemented as a well-known type either yet, but I believe it's perfectly fine to cover it in the deserializer for the time being and accept "123", 123 in addition to the existing { "value", "123" } schema.

Describe the solution you'd like

Accept "123", 123 in addition to the existing { "value", "123" } schema. This may need some options to prevent change in behavior esp. when serializing.

Alternatives

Another way to do this is to let users write their own json converters, but this API is not public right now. (#46712)

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Oct 20, 2023
@martincostello martincostello added area-grpc Includes: GRPC wire-up, templates and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Oct 20, 2023
@alrz
Copy link
Contributor Author

alrz commented Oct 27, 2023

tagging @JamesNK, I'm interested to do this if this is something you'd consider for gRPC transcoding support. There's only a few open questions that I'd like to to be addressed beforehand. Thanks.

@alrz
Copy link
Contributor Author

alrz commented Dec 6, 2023

Closing in favor of #46712, custom converters would be a superset of this request.

@alrz alrz closed this as completed Dec 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Development

No branches or pull requests

2 participants