Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-built aspnetcore fails during rollup on ppc64le #54393

Closed
tmds opened this issue Mar 6, 2024 · 18 comments
Closed

source-built aspnetcore fails during rollup on ppc64le #54393

tmds opened this issue Mar 6, 2024 · 18 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Status: Resolved
Milestone

Comments

@tmds
Copy link
Member

tmds commented Mar 6, 2024

The build is failing as follows:

    > build:debug
    > rollup -c --environment development --forceExit
    
    /home/tester/dotnet/src/aspnetcore/node_modules/rollup/dist/native.js:38
    	throw new Error(
    	^
    
  EXEC : error : Your current platform "linux" and architecture "ppc64" combination is not yet supported by the native Rollup build. Please use the WASM build "@rollup/wasm-node" instead. [/home/tester/dotnet/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj]
  ##vso[task.logissue type=error;sourcepath=EXEC;linenumber=0;columnnumber=0;code=;]Your current platform "linux" and architecture "ppc64" combination is not yet supported by the native Rollup build. Please use the WASM build "@rollup/wasm-node" instead.

cc @Swapnali911 @MichaelSimons @omajid

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 6, 2024
@mkArtakMSFT
Copy link
Member

@javiercn any recommendation regarding this one? Is this an important step that is required to run as part of the build, or can it be skipped on this particular platform?

@mkArtakMSFT
Copy link
Member

@mthalman, @MichaelSimons do you know if this distro is something we MUST support or not?

@javiercn
Copy link
Member

javiercn commented Mar 6, 2024

@mkArtakMSFT this might require installing "@rollup/wasm-node" and potentially overriding rollup with an npm override.

@MichaelSimons
Copy link
Member

@mthalman, @MichaelSimons do you know if this distro is something we MUST support or not?

ppc64le is community supported meaning principally community-driven contributions with best effort support from Microsoft.

cc @leecow

@omajid
Copy link
Member

omajid commented Mar 6, 2024

Comparing rollup with System.Runtime.InteropServices.Architecture, it looks like rollup doesn't support a number of .NET architectures, including loongarch, ppc64le, s390x and x86.

@omajid
Copy link
Member

omajid commented Mar 6, 2024

cc @uweigand @Vishwanatha-HD

@uweigand
Copy link
Contributor

uweigand commented Mar 8, 2024

Looks like there is already some community effort to get a s390x build of rollup going: rollup/rollup#5346 ... I'll see if can help that succeed.

@tmds
Copy link
Member Author

tmds commented Mar 13, 2024

Looks like there is already some community effort to get a s390x build of rollup going: rollup/rollup#5346 ... I'll see if can help that succeed.

@Swapnali911 @janani66 there's a similar PR for ppc64le: rollup/rollup#5350. You may want to look into that.

this might require installing "@rollup/wasm-node" and potentially overriding rollup with an npm override.

@javiercn @mkArtakMSFT does "@rollup/wasm-node" provide an alternative option that would work on both ppc64le and s390x?

@Swapnali911
Copy link

Looks like there is already some community effort to get a s390x build of rollup going: rollup/rollup#5346 ... I'll see if can help that succeed.

@Swapnali911 @janani66 there's a similar PR for ppc64le: rollup/rollup#5350. You may want to look into that.

this might require installing "@rollup/wasm-node" and potentially overriding rollup with an npm override.

@javiercn @mkArtakMSFT does "@rollup/wasm-node" provide an alternative option that would work on both ppc64le and s390x?

@tmds will check

@sec
Copy link
Contributor

sec commented Mar 15, 2024

So any workaround for now?

@uweigand
Copy link
Contributor

As of version 4.13.1, rollup now supports s390x and provides a linux-s390x prebuilt binary:
https://www.npmjs.com/package/@rollup/rollup-linux-s390x-gnu

@sec
Copy link
Contributor

sec commented Mar 28, 2024

What about other OS'es? Having rollup used in build process, makes it "hard" to port to other platforms :)

@uweigand
Copy link
Contributor

As of version 4.13.1, rollup now supports s390x and provides a linux-s390x prebuilt binary: https://www.npmjs.com/package/@rollup/rollup-linux-s390x-gnu

And as of version 4.13.2, ppc64le support is also present: https://www.npmjs.com/package/@rollup/rollup-linux-powerpc64le-gnu

So I think the only missing piece would be to upgrade the required rollup version in the aspnetcore package.json file.

@sec
Copy link
Contributor

sec commented Mar 28, 2024

Still no FreeBSD in there, so maybe some option to use the wasm one would be helpfull to have also in case of fallback?

@uweigand
Copy link
Contributor

And as of version 4.13.2, ppc64le support is also present.

Turns out this wasn't quite correct; ppc64le support is fixed in version 4.14.2 now.

@sec
Copy link
Contributor

sec commented May 7, 2024

Are there any plans regarding this one? Previous 8.x and 9p1 build fine, but starting from 9p2 this issue is blocking native builds under FreeBSD (and probably other OS'es not supported atm by rollup) - any "easy" to fallback to @rollup/wasm-node while doing VMR build ?

@mkArtakMSFT
Copy link
Member

mkArtakMSFT commented May 21, 2024

We'll try to prioritize this for preview 6 release.
@wtgodbe , @javiercn FYI

@mkArtakMSFT mkArtakMSFT added this to the 9.0-preview6 milestone May 21, 2024
@mkArtakMSFT
Copy link
Member

Closing this as a dupe of #54541 as that's the one we'll use for tracking this work.

@mkArtakMSFT mkArtakMSFT closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@mkArtakMSFT mkArtakMSFT added the ✔️ Resolution: Duplicate Resolved as a duplicate of another issue label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework ✔️ Resolution: Duplicate Resolved as a duplicate of another issue Status: Resolved
Projects
None yet
Development

No branches or pull requests

9 participants