-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-built aspnetcore fails during rollup on ppc64le #54393
Comments
@javiercn any recommendation regarding this one? Is this an important step that is required to run as part of the build, or can it be skipped on this particular platform? |
@mthalman, @MichaelSimons do you know if this distro is something we MUST support or not? |
@mkArtakMSFT this might require installing "@rollup/wasm-node" and potentially overriding rollup with an npm override. |
ppc64le is community supported meaning principally community-driven contributions with best effort support from Microsoft. cc @leecow |
Comparing rollup with System.Runtime.InteropServices.Architecture, it looks like rollup doesn't support a number of .NET architectures, including loongarch, ppc64le, s390x and x86. |
Looks like there is already some community effort to get a s390x build of rollup going: rollup/rollup#5346 ... I'll see if can help that succeed. |
@Swapnali911 @janani66 there's a similar PR for ppc64le: rollup/rollup#5350. You may want to look into that.
@javiercn @mkArtakMSFT does "@rollup/wasm-node" provide an alternative option that would work on both ppc64le and s390x? |
@tmds will check |
So any workaround for now? |
As of version 4.13.1, rollup now supports s390x and provides a linux-s390x prebuilt binary: |
What about other OS'es? Having rollup used in build process, makes it "hard" to port to other platforms :) |
And as of version 4.13.2, ppc64le support is also present: https://www.npmjs.com/package/@rollup/rollup-linux-powerpc64le-gnu So I think the only missing piece would be to upgrade the required rollup version in the aspnetcore package.json file. |
Still no FreeBSD in there, so maybe some option to use the wasm one would be helpfull to have also in case of fallback? |
Turns out this wasn't quite correct; ppc64le support is fixed in version 4.14.2 now. |
Are there any plans regarding this one? Previous 8.x and 9p1 build fine, but starting from 9p2 this issue is blocking native builds under FreeBSD (and probably other OS'es not supported atm by rollup) - any "easy" to fallback to |
Closing this as a dupe of #54541 as that's the one we'll use for tracking this work. |
The build is failing as follows:
cc @Swapnali911 @MichaelSimons @omajid
The text was updated successfully, but these errors were encountered: