Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Image on button not scaling down for all scenarios when dimensions are less than button #21683

Closed
PureWeen opened this issue Apr 6, 2024 · 0 comments · Fixed by #22276
Closed

[Windows] Image on button not scaling down for all scenarios when dimensions are less than button #21683

PureWeen opened this issue Apr 6, 2024 · 0 comments · Fixed by #22276
Assignees
@Foda
Labels
area-controls-button Button, ImageButton partner/cat 😻 Client CAT Team platform/windows 🪟
Milestone
.NET 8 SR6

Comments

@PureWeen
Copy link
Member

PureWeen commented Apr 6, 2024

Description

<VerticalStackLayout>
    <Button ImageSource="dotnet_bot.png" WidthRequest="60" HeightRequest="100" Text="Hi there">
    </Button>
</VerticalStackLayout>

Result

Windows:
image

Android:
image
@PureWeen PureWeen added this to the .NET 8 SR4 milestone Apr 6, 2024
This was referenced Apr 8, 2024
Closed
Closed
@PureWeen PureWeen modified the milestones: .NET 8 SR4, .NET 8 SR5 Apr 18, 2024
@PureWeen PureWeen added partner Issue or Request from a partner team partner/cat 😻 Client CAT Team platform/windows 🪟 legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-button Button, ImageButton and removed partner Issue or Request from a partner team labels Apr 24, 2024
@PureWeen PureWeen modified the milestones: .NET 8 SR5, .NET 8 SR6 May 1, 2024
@Foda Foda mentioned this issue May 7, 2024
Merged
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Foda added a commit that referenced this issue May 15, 2024
@Foda
[Windows] Clamp images inside buttons to button width/height (#22276)
374e9dd 
### Description of Change

This PR forces images inside buttons to always fit inside the available
space, rather than expand be clipped

### Issues Fixed

Fixes #21683
#21970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Foda Foda

Labels
area-controls-button Button, ImageButton partner/cat 😻 Client CAT Team platform/windows 🪟
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 8 SR6
3 participants
@Eilon @Foda @PureWeen