Memory leak with Shell Navigation

[AshokKumarVis96]

Description

With Maui Shell Navigation, we could see some page are not disposed properly when we are not using them as Routed page.

In provided sample, we have 3 Shell Pages, in which Main Page & First Page is not registered as routed page. Second Page is added as routed Page. After Navigating through these page, only MainPage & FirstPage is not releasing its object, like Second Page.

Note: We are using memory toolkit to monitor the memory leaks. Reference : https://github.com/AdamEssenmacher/MemoryToolkit.Maui?tab=readme-ov-file

Steps to Reproduce

1. Run the below provided sample in Android/ iOS.
2. Main Page will be opened, Click on 'Move to First Page'
3. Once First Page is opened, Click on 'Move to Second Page'
4. Once Second Page is opened, Click on Back button in Navigation toolbar
5. Now Check the output window, We can see the list of objects which are not disposed.(Refer below screenshot)

We can see, objects of Second Page will be released properly, not with First and Main page.

Link to public reproduction project repository

Replication Sample

Version with bug

8.0.21 SR4.1

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

8.0.0-rc.1.9171

Affected platforms

iOS, Android

Affected platform versions

Android 13, iOS 15.0

Did you find any workaround?

Registering Route for Affected pages in AppShell.Xaml.cs, resolves the issue.

Relevant log output

[shellmemoryleak] Explicit concurrent mark compact GC freed 17074(1945KB) AllocSpace objects, 4(144KB) LOS objects, 58% free, 4387KB/10MB, paused 90us,1.498ms total 12.673ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 1231(104KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4347KB/10MB, paused 51us,1.437ms total 9.896ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 15(64KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4347KB/10MB, paused 101us,2.365ms total 16.422ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 7(64KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4347KB/10MB, paused 57us,1.408ms total 11.902ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 7(64KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4347KB/10MB, paused 71us,1.450ms total 10.240ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 7(64KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4347KB/10MB, paused 81us,2.266ms total 15.936ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 7(64KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4347KB/10MB, paused 151us,2.123ms total 15.141ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 7(64KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4347KB/10MB, paused 90us,1.973ms total 14.553ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 7(64KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4347KB/10MB, paused 90us,2.229ms total 16.963ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 7(64KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4347KB/10MB, paused 98us,2.352ms total 16.999ms
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗Label is a zombie
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗LabelHandler is a zombie
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗Label is a zombie
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗LabelHandler is a zombie
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗Button is a zombie
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗ButtonHandler is a zombie
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗VerticalStackLayout is a zombie
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗LayoutHandler is a zombie
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗MainPage is a zombie
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Warning: ❗🧟❗PageHandler is a zombie
[ViewRootImpl@51f174d[MainActivity]] ViewPostIme pointer 0
[ViewRootImpl@51f174d[MainActivity]] ViewPostIme pointer 1
[WindowOnBackDispatcher] sendCancelIfRunning: isInProgress=falsecallback=androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1@6d5a864
[ViewRootImpl@51f174d[MainActivity]] ViewPostIme pointer 0
[ViewRootImpl@51f174d[MainActivity]] ViewPostIme pointer 1
[WindowOnBackDispatcher] sendCancelIfRunning: isInProgress=falsecallback=androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1@6d5a864
[shellmemoryleak] Cleared Reference was only reachable from finalizer (only reported once)
[shellmemoryleak] Explicit concurrent mark compact GC freed 2603(200KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4403KB/10MB, paused 92us,1.888ms total 15.402ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 1039(136KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4363KB/10MB, paused 71us,1.992ms total 13.601ms
[shellmemoryleak] Explicit concurrent mark compact GC freed 107(68KB) AllocSpace objects, 0(0B) LOS objects, 58% free, 4359KB/10MB, paused 98us,2.455ms total 16.666ms
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Information: ✅Label released
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Information: ✅LabelHandler released
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Information: ✅Label released
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Information: ✅LabelHandler released
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Information: ✅VerticalStackLayout released
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Information: ✅LayoutHandler released
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Information: ✅SecondPage released
[0:] MemoryToolkit.Maui.GarbageCollectionMonitor: Information: ✅PageHandler released

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

• Memory leak when using shell navigation on Android (#21853), similarity score: 0.79

Closed similar issues:

• .NET MAUI Shell app page navigation memory leaks (#15930), similarity score: 0.82
• Memory Leak on Page Navigation while removing the page. (#21403), similarity score: 0.81
• Memory leak while repeatedly navigating between pages (#10578), similarity score: 0.79
• Memory Leak on back and Fro navigation on page where Custom control and complex View Page (#21404), similarity score: 0.77

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[AshokKumarVis96]

ShellMemoryLeak.zip

[Zhanglirong-Winnie]

Verified this issue with Visual Studio 17.10 Preview 6.0 (8.0.21 & 8.0.3). Can repro on iOS and android platforms with sample project.

We tried to use 8.0.0-rc.1.9171 in the sample project to verify this issue and encountered the following error:

[AshokKumarVis96]

Verified this issue with Visual Studio 17.10 Preview 6.0 (8.0.21 & 8.0.3). Can repro on iOS and android platforms with sample project. -> Yes @Zhanglirong-Winnie

[AshokKumarVis96]

We tried to use 8.0.0-rc.1.9171 in the sample project to verify this issue and encountered the following error: -> @Zhanglirong-Winnie Please try with Microsoft.Maui.Controls 8.0.3 version.