Migrate to Azure.Data.Tables SDK for Azure Table Storage #7300
+1,030
−1,052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
migrate/azure-table-storage
branch
from
ae0ed16 to
55ee387
Compare
christothes
reviewed
Sep 24, 2021
src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs
Outdated
Show resolved
Hide resolved
src/Azure/Orleans.GrainDirectory.AzureStorage/AzureTableGrainDirectory.cs
Show resolved
Hide resolved
src/Azure/Orleans.Persistence.AzureStorage/Storage/StorageExceptionExtensions.cs
Show resolved
Hide resolved
.../Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs
Show resolved
Hide resolved
.../Orleans.Transactions.AzureStorage/TransactionalState/AzureTableTransactionalStateStorage.cs
Outdated
Show resolved
Hide resolved
jsquire
reviewed
Sep 24, 2021
src/Azure/Orleans.Clustering.AzureStorage/OrleansSiloInstanceManager.cs
Outdated
Show resolved
Hide resolved
ReubenBond
force-pushed
the
migrate/azure-table-storage
branch
from
2481a36 to
c7cb4c2
Compare
ReubenBond
force-pushed
the
migrate/azure-table-storage
branch
from
c7cb4c2 to
3113691
Compare
src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorageOptions.cs
Outdated
Show resolved
Hide resolved
src/Azure/Orleans.Persistence.AzureStorage/Providers/Storage/AzureBlobStorageOptions.cs
Outdated
Show resolved
Hide resolved
ReubenBond
force-pushed
the
migrate/azure-table-storage
branch
from
e3c9a80 to
8267375
Compare
|
We can address the Event Hubs provider in a separate PR - it can also take advantage of a wider variety of authentication options |
ReubenBond
force-pushed
the
migrate/azure-table-storage
branch
from
140768e to
8267375
Compare
shmurchi
pushed a commit
to shmurchi/orleans
that referenced
this pull request
Oct 28, 2021
* Migrate to Azure.Data.Tables SDK for Azure Table Storage * PR feedback * Reduce use of Tuple and other minor inefficiencies * Add helper methods for setting Azure Storage credentials * Table & Blob storage config updates * Fix test usages of table & blob storage config
ReubenBond
added a commit
to shmurchi/orleans
that referenced
this pull request
Nov 9, 2021
* Migrate to Azure.Data.Tables SDK for Azure Table Storage * PR feedback * Reduce use of Tuple and other minor inefficiencies * Add helper methods for setting Azure Storage credentials * Table & Blob storage config updates * Fix test usages of table & blob storage config
ReubenBond
added a commit
that referenced
this pull request
Nov 16, 2021
* Migrate to Azure.Data.Tables SDK for Azure Table Storage (#7300) * Migrate to Azure.Data.Tables SDK for Azure Table Storage * PR feedback * Reduce use of Tuple and other minor inefficiencies * Add helper methods for setting Azure Storage credentials * Table & Blob storage config updates * Fix test usages of table & blob storage config * Add deprecation messages * Support additional authentication options for Azure Event Hub streams provider Co-authored-by: Reuben Bond <203839+ReubenBond@users.noreply.github.com> Co-authored-by: ReubenBond <rebond@microsoft.com>
starcraft66
added a commit
to starcraft66/orleans
that referenced
this pull request
Nov 18, 2021
…net#7300) (dotnet#7363)" This reverts commit 12a9c88.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates Orleans' Azure Table Storage SDK from
Microsoft.Azure.Cosmos.TabletoAzure.Data.Tables, which required many changes due to API differences.Since the new library includes native support for Azure Active Directory authentication, I removed the custom TokenCredential code which we had previously and added all of the new authentication options to Tables/Blobs/Storage options, as well as a property on each which allows the developer to supply a delegate used to construct the respective service clients
cc @jsquire @christothes