Timeout in System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers

[lewing]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=646861
Build error leg or test failing: System.Text.Json.Tests.WorkItemExecution
Pull request: #101140

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": [ "Takes very long to run on interpreter.", "System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers", "['System.Text.Json.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]"],
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=646861
Error message validated: [Takes very long to run on interpreter. System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers ['System.Text.Json.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/17/2024 5:06:43 PM UTC

Report

Build	Definition	Test	Pull Request
678721	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution
678685	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution	#102362
678603	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution	#102357
678577	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution
678427	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution	#102351
671701	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution
664107	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution
664022	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution	#101828
663982	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution
663692	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution	#101818
663649	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution
663382	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution	#101807
661263	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution
658219	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution
658149	dotnet/runtime	System.Text.Json.Tests.WorkItemExecution	#101645

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	0	15

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[lewing]

See the discussion in #59678 for context

[lewing]

This was written to try to catch
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-101122-merge-004d05ddb3b041639a/System.Text.Json.Tests/1/console.8d81d47f.log?helixlogtype=result

/datadisks/disk1/work/9B2B0894/w/B43409F0/e /datadisks/disk1/work/9B2B0894/w/B43409F0/e
  Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Text.Json.Tests (found 7405 of 7466 test cases)
  Starting:    System.Text.Json.Tests (parallel test collections = on [2 threads], stop on fail = off)
    System.Text.Json.Tests.Utf8JsonReaderTests.TestDepth(depth: 256) [SKIP]
      Takes very long to run on interpreter.
    System.Text.Json.Tests.Utf8JsonReaderTests.TestDepth(depth: 512) [SKIP]
      Takes very long to run on interpreter.
   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Tests.Utf8JsonWriterTests.Writing3MBBase64Bytes', Elapsed: 00:05:42
   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers', Elapsed: 00:02:01
   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Tests.Utf8JsonWriterTests.WriteNumbers', Elapsed: 00:04:01
Killed
['System.Text.Json.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

as explicitly as possible but there are a lot of other forms of timeouts for wasm

[lewing]

@BrzVlad the particular failure this issue seems to catch looks like it is specfic to the desktop interpreter, can you take a look?

[dotnet-policy-service]

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

[BrzVlad]

I did a few runs locally and I'm not seeing anything suspicious. It just looks like a heavy suite that takes a long time to run. Also I'm seeing that all these failures are on debug builds. While for jit/aot, debug build doesn't have a big impact, the interpreter execution engine is written in C and it can easily get 3x slower in debug build.

I'm not sure if it easy to do, but I think this test suite should be disabled on interpreter debug builds

[BrzVlad]

Disabled suite in debug runtime builds in /github.com//pull/101483

[lewing]

reopening since a few builds weren't against the tip of main and hit this, feel free to close again next week