Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731

Closed
JulieLeeMSFT opened this issue Apr 30, 2024 · 13 comments · Fixed by #101800 or #102098
Closed

Test failure in System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101731

JulieLeeMSFT opened this issue Apr 30, 2024 · 13 comments · Fixed by #101800 or #102098
Assignees
@tannergooding
Labels
area-System.Numerics.Tensors blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Milestone
9.0.0

Comments

@JulieLeeMSFT
Copy link
Member

JulieLeeMSFT commented Apr 30, 2024 •
edited by build-analysis bot

Failed in runtime-coreclr libraries-jitstress2-jitstressregs

Stack Trace:
        /_/src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs(444,0): at System.Numerics.Tensors.Tests.GenericFloatingPointNumberTensorPrimitivesTests`1.SpanDestinationFunctions_SpecialValues(SpanDestinationDelegate tensorPrimitivesMethod, Func`2 expectedMethod, Nullable`1 tolerance)
           at InvokeStub_GenericFloatingPointNumberTensorPrimitivesTests`1.SpanDestinationFunctions_SpecialValues(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.Numerics.Tensors.Net8.Tests

Known Issue Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "GenericFloatingPointNumberTensorPrimitivesTests`1.SpanDestinationFunctions_SpecialValues",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=660140
Error message validated: [GenericFloatingPointNumberTensorPrimitivesTests1.SpanDestinationFunctions_SpecialValues`]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 5/1/2024 3:48:58 AM UTC

Report

Build Definition Test Pull Request
673999 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102139
673838 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101089
673835 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101089
673791 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102071
673764 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101796
673751 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102153
673739 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102094
673732 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102073
673659 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101801
673625 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #100141
673533 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101717
673376 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102133
673360 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102076
2449946 dotnet-runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
673323 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102146
673321 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
673269 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102139
673259 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101938
673175 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102139
2449760 dotnet-runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
673149 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
673144 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102094
673122 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102103
673116 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102132
673112 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102117
2449738 dotnet-runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
673059 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102133
673035 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102129
672997 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102132
672936 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101977
672919 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101975
672901 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102126
672831 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
672823 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102103
672709 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102084
672661 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102115
672788 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102126
672783 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102059
672395 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102101
672392 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102101
672246 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102104
672212 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101580
672195 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101938
672189 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101938
672168 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102059
672162 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101652
672137 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102098
672029 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102084
671966 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101994
671945 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102007
671929 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
671855 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101580
671775 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102089
671766 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101938
671694 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #85694
671685 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101994
671671 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101950
671627 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101683
671606 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102074
671571 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101976
671557 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101295
671510 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102076
671494 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101717
671452 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101975
671428 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102024
671436 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101801
671306 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
671274 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101938
671231 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102007
671217 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101994
671098 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101701
671020 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102062
670921 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102058
670861 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101938
670895 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
670824 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101580
670810 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
670746 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102054
670704 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #100745
670675 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102036
670627 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101938
670590 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101801
665989 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101848
670466 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101796
670463 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101976
670443 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101801
670387 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101620
670311 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #100266
670269 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102041
670263 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues
670214 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101938
670169 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #98127
670074 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101886
670041 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101994
670017 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102036
669967 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102035
669961 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #102034
669779 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101886
669929 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #100823
669901 dotnet/runtime System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues #101580
Displaying 100 of 212 results

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
21 147 212
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 30, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics-tensors
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Apr 30, 2024
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Apr 30, 2024
@JulieLeeMSFT
Copy link
Member Author

It looks similar to #97297.

@JulieLeeMSFT
Copy link
Member Author

Looks similar in runtime-coreclr libraries-jitstressregs

 Stack Trace:
           at InvokeStub_GenericFloatingPointNumberTensorPrimitivesTests`1.SpanDestinationFunctions_SpecialValues(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.Numerics.Tensors.Tests

@JulieLeeMSFT
Copy link
Member Author

@tannergooding, PTAL.

@tannergooding
Copy link
Member

I can take a look and see if I can find an initial root cause, but I expect this is likely a JIT issue and unrelated to the libraries side of things.

CC. @jeffhandley

@stephentoub stephentoub mentioned this issue Apr 30, 2024
Merged
@jkotas jkotas added the Known Build Error Use this to report build issues in the .NET Helix tab label May 1, 2024
@jkotas jkotas mentioned this issue May 1, 2024
Merged
@JulieLeeMSFT
Copy link
Member Author

It is now failing in Runtime pipeline as well. Please see the Known issue report above.

@tannergooding tannergooding mentioned this issue May 2, 2024
Merged
@kunalspathak kunalspathak mentioned this issue May 5, 2024
Merged
@kunalspathak
Copy link
Member

This seems to be still failing in #101859 which included the fix made in #101800

@jkotas
Copy link
Member

jkotas commented May 6, 2024

It is failing on #101767 with the fix.

@jkotas jkotas reopened this May 6, 2024
@stephentoub
Copy link
Member

e.g.

    System.Numerics.Tensors.Tests.SingleGenericTensorPrimitives.SpanDestinationFunctions_SpecialValues(tensorPrimitivesMethod: SpanDestinationDelegate { Method = Void ReciprocalSqrtEstimate[Single](System.ReadOnlySpan`1[System.Single], System.Span`1[System.Single]), Target = null }, expectedMethod: Func`2 { Method = Single ReciprocalSqrtEstimate(Single), Target = null }, tolerance: 0.01171875) [FAIL]
      Assert.All() Failure: 256 out of 256 items in the collection did not pass.
      [0]:   Item:  1
             Error: Assert.All() Failure: 2 out of 24 items in the collection did not pass.
                    [12]: Item:  -1.40129846E-45
                          Error: Assert.Equal() Failure: Values differ
                                 Expected: -�
                                 Actual:   NaN
                    [14]: Item:  -1.17549421E-38
                          Error: Assert.Equal() Failure: Values differ
                                 Expected: -�
                                 Actual:   NaN
...

@jkotas jkotas added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' and removed blocking-clean-ci-optional Blocking optional rolling runs labels May 8, 2024
@tannergooding
Copy link
Member

I'm not able to reproduce the failure locally, on a machine with or without AVX512.

My best guess is that in some edge case scenario the code is calling the fallback instead of allowing the intrinsic implementation to kick in.

Changing it to be mustExpand with no managed implementation should avoid any potential for that, so that's what I'll get a fix up to do.

@EgorBo
Copy link
Member

EgorBo commented May 12, 2024 •
edited

Should we disable this test for now? it's been blocking clean CI for two weeks now (e.g. I've just hit it in #102132)

@tannergooding tannergooding mentioned this issue May 13, 2024
Merged
@tannergooding
Copy link
Member

The issue is fixed with #102098 and so disabling shouldn't be needed, just final sign-off

If, for whatever reason, the test still shows as flaky somewhere after then I think we can disable it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tannergooding tannergooding

Labels
area-System.Numerics.Tensors blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Milestone
9.0.0
6 participants
@EgorBo @stephentoub @jkotas @tannergooding @kunalspathak @JulieLeeMSFT