-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #92296 and #92438 to release/6.0-staging #101822
Backport #92296 and #92438 to release/6.0-staging #101822
Conversation
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
964d141
to
0d5c19b
Compare
/azp run runtime |
Azure Pipelines failed to run 1 pipeline(s). |
Failures in public CI are known |
ping @agocke (sorry, I didn't realize Jeremy is out of office at the moment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. FYI, if the PGO build is broken, we probably won't find the issue until it flows up the stack. There's nothing to do about that, it's just the way it works.
Thank you!
I see, I'll keep this in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we can treat this as tell mode, merge when ready
e50e868
into
dotnet:release/6.0-staging
This is the first of multiple PRs to replicate @eduardo-vp's work of merging commits needed to transition the
release/6.0-staging
branch to 1ES pipeline templates. Because this branch andmain
have diverged quite a bit, I found it safer to manually merge each change by hand, rather than relying ongit cherry-pick
. As such, this PR probably warrants extra scrutiny...Official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2448493&view=results
cc @agocke @jkoritzinsky