-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: files missing from solution explorer with multi-targeting #2337
Comments
Spoke to @jamesmontemagno yesterday about this, but he mentioned the issue he was running into was https://developercommunity.visualstudio.com/content/problem/268967/multi-targeting-project-with-conditionally-include.html, so clearly lead him down the wrong path. This is #1157 & dotnet/project-system#3181 and was a deliberate change in the SDK. |
The tree is generated based on the configuration and has always been the case in the new project system. You can try this by placing a condition to only include a file in DEBUG and then switch to RELEASE, and we'll update the tree to remove the file. TFMs are considered a dimension in a configuration, you just can't change the "active" one. I'm not sure I understand the erroneous entries what is the exact steps? |
Something bad changed in the behavior though, perhaps due to the #1157, but this makes working with other tfm's other than the first, active one, impossible now. |
There has been zero changes in the way we handle this in VS, this is an SDK-only change. VS will go out of its way to avoid double-including an item, which has been the behavior since VS 2017 RTM. File separate bugs for the VS behavior, with a clear "actual" and "expected" so I can understand your expectation. |
This behavior is exactly how it was designed and has been the same for ~2 years, under the following constraints:
The behavior above can be described by the last two constraints. This behavior however is separate to the SDK change and hence, if you'd like to see a different behavior please file a new bug over http://github.com/dotnet/project-system. |
@davkean Happy to file a new issue or add to an existing one. I assume that the single TFM issue is the main issue; is there an open issue for that? |
The tree is completely based around a "configuration", we represent TFMs a dimension of a configuration; debug|anycpu|net45 and debug|anycpu|netstandard20, etc. I think this bug you opened two years ago; dotnet/project-system#935 is the bug that best represents this the tree manipulation. The (avoid) double-including of a file behavior is slightly different issue and we should treat separately. I'm completely open to better ideas how to handle this but it is a bloody hard problem to solve and gets very complex very quickly. |
The double-including behavior doesn't bother me as much for now (unless it causes other issues). Is solving dotnet/project-system#935 still in scope for 16.0? Like, can we think about how to solve it? |
The original issue outlined is a change in functionality from 15.7.1 to 15.7.3. essentially the valuations for the tree stop. In 15.7.1 all files showed correct and 15.7.3 they stopped. They other issue of it addijg Includes I think has always been there, we manually delete them, it is more annoying then anything, but different then the original issue, so we should focus on that if possible. |
Just to clear things up a little;
While it "appears" that the files shown are correct, they are shown with the wrong item type. If you were to manipulate the item's properties, it would not behave as you would expect. It looks like we/you got lucky that we correctly recognize these files as "source files" and they displayed correctly in the editor. This most definitely was not a "designed thing" and kinda just fell out of our implementation. The entire "how do we display multiple TFMs source files" was being tracked by dotnet/project-system#935. I'm not sure what to do this with this at this point, and will need to sync up with the SDK folks to discuss. @dsplaisted Can we discuss in our Monday sync-up? |
@davkean What do you mean by the patch version of VS? If a version like 15.7.3 is major.minor.patch, then we wouldn't put a change like this in a patch update to VS. We would (and did) put an update like this in a minor update. For the SDK we don't really have a difference between major and minor updates, since we release both with Visual Studio and with .NET Core, which can release major versions on different schedules. |
@dsplaisted @jamesmontemagno and @onovotny mentioned that this was regressed between 15.7.1 to 15.7.3. |
@jamesmontemagno Is it possible that when testing on 15.7.3, that the .NET Core SDK 2.1.300 was installed, while only 2.1.200 was installed together with 15.7.1? |
That is possible. |
I am on 15.7.3 + 2.1.300. I can try to go back down to 2.1.200 |
@jamesmontemagno Yes, it would be helpful if you could try it on 2.1.200 just so we're sure about what causes this. |
So some results here on my work machine:
|
So, now with 15.7.4 still same issue with 2.1.300 sdk, however once I delete 2.1.300 from the dotnet/sdk folder it continues to work again, so it looks like there was a change here that is making it happen. |
Also for reference the reason i had 2.1.300 was for blazor demos |
@jamesmontemagno Thanks, this confirms that the behavior you're seeing is the result of what we thought it was: namely, the fix to #1157 and dotnet/project-system#3181. We will discuss what we can do here to make it easier to browse conditionally included source files in a multi-targeted project. As a workaround, you can try adding something like this to your project file (after any <None Include="**\*.cs" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder);@(Compile)" /> |
@onovotny If you add |
@onovotny @jamesmontemagno Can you try the following "workaround"? <ItemGroup>
<None Include="**/*.cs" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder);$(Compile)" />
</ItemGroup> This should go after any This should get you back to the pre-2.1.300 SDK behavior, where all the source code will show in the solution explorer, but various things (adding new items, moving, renaming) in the IDE may not work or may work strangely. So I don't recommend adding this arbitrarily to all projects, just projects where you have TargetFramework-specific source files that you want to show up in solution explorer. |
I'm going to close this issue, as we believe we understand the behavior change here, and the real fix is for solution explorer to show files from all the target frameworks, which is tracked by dotnet/project-system#935. |
Can confirm the workaround works. |
Small nit on the workaround: shouldn't that be |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [MSBuild.Sdk.Extras](https://togithub.com/novotnyllc/MSBuildSdkExtras) | `1.6.61` -> `1.6.68` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/MSBuild.Sdk.Extras/1.6.68?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/MSBuild.Sdk.Extras/1.6.68?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/MSBuild.Sdk.Extras/1.6.61/1.6.68?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/MSBuild.Sdk.Extras/1.6.61/1.6.68?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>novotnyllc/MSBuildSdkExtras (MSBuild.Sdk.Extras)</summary> ### [`v1.6.68`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v1.6.68) #### Changes: - [`3f71919`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/3f71919049e95d4eeef4ea6fbc9fea080544c8c8) Don't set MSBuildAllProjects for MSBuild >= 16. Older versions still get it. - [`0d5d333`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/0d5d333f471865c72626d5cd672efa8e8c4bc8de) Use the 6.1.9 uwp package - [`76e3d53`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/76e3d53067d1195c06ece86e72a23548fbe7fc48) Ensure inner builds batch \[ [#​154](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/154) ] - [`4af4335`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/4af4335d21b2e656453ab338f5c3d7283927454f) Bump implicit uwp package version - [`b280e17`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/b280e174bde50e9d1ab2e9f5972b7e6d6181cec0) Update implicit Tizen.NET version - [`957e7f6`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/957e7f69a1494d423f6d1261a396b1ffeea89f19) Add extra safety check - [`1e37f53`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/1e37f5327628881855e18fd70d2784acc1d4d2fe) Fixes to allow restore and build on macOS - [`1432809`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/1432809a0ddb42cbc4b378ce4e8fbb985792fa6a) Find C#/VB targets using MSBuildToolsVersion \[ [#​127](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/127), [icrosoft/msbuild#3778](https://togithub.com/icrosoft/msbuild/issues/3778) ] - [`80092d4`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/80092d4741e99d727ad3839292d24a064faa6b9e) Fix UWP packing bug - [`602fa5c`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/602fa5c4dec46e402f3d4ac513d217ad06f02123) rename file <details><summary><b>See more</b></summary> - [`a191f25`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/a191f25af774191976b8875a81314a88ae3e9826) consolidate build files - [`6949f22`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/6949f2297c07eb9478a50224256c217563a77fd4) Update .vsts-shared.yml - [`9212ca9`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/9212ca99b2f05e2877af988ebc7cb77b92bfd017) build updates - [`2c33705`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/2c3370531476f6654cebdf46c104dccc36c3060d) Ensure sdk props are imported before our props for legacy packageref \[ [#​114](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/114) ] - [`a0e0353`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/a0e03539208a2f81e8479edbe525ce773cfd0146) Ensure we define a default GetPackagingOutputs since it always needs to be present. \[ [#​115](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/115) ] - [`2b8299c`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/2b8299cdfbc9e94cd09096495e41611ba7a2e622) Ensure TPMV is set for Win8.x \[ [#​116](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/116) ] - [`59264b7`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/59264b71e30eb405383e0e3dd93d9939daaecf65) Ensure we conly import the portable targets once. \[ [#​105](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/105) ] - [`1820b4a`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/1820b4af10f8388473a1a0d8b182e8024a849a57) Ensure portable-tfm1+tfm2 are propertly escaped for defines. \[ [#​106](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/106) ] - [`493d99f`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/493d99fd1c40a1f5f10548058c9cac25bac9c2c3) Update UWP package - [`cc71386`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/cc713861438e072effd1cd10da4f7f697105e04f) fix compare - [`22607fc`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/22607fc57582fab2078f49cd68f56b14c408644f) Only none-include if default compile items are off - [`bc948cc`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/bc948cc5b36aa556e50daed32239025ede860e59) Add workaround for [dotnet/sdk#2337 into the Extras - [`bcc5cee`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/bcc5ceec29f4c28356599c9f3a5d18b239f286f3) Fix regression in NuGetTargetMoniker for Win8. Fixes [#​100](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/100) - [`d9b1c74`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/d9b1c74850cf584903fc45bce15965b066c5a9c2) Rename private var - [`cd7f59c`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/cd7f59c434794fc92d6219fc301bfa7455f05bd4) Move to props - [`9f802b1`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/9f802b10f5c084fb609b062072508dc41834051b) Add the missing "v" to <TargetFrameworkVersion> - [`e23c37b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/e23c37b1e07904b85ee496f65721dfc638ab101a) Fixing wrong resource include rule - [`045f19b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/045f19b94b6de27867c929a6f444274ae00da6b0) fix for target that is only in .4xx - [`42c5312`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/42c53126021049c16c014a472542c659695b6877) stable ver This list of changes was [auto generated](https://dev.azure.com/onovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=653&\_a=release-summary).</details> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/reactiveui/ReactiveUI). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [MSBuild.Sdk.Extras](https://togithub.com/novotnyllc/MSBuildSdkExtras) | `1.6.68` -> `3.0.44` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/MSBuild.Sdk.Extras/3.0.44?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/MSBuild.Sdk.Extras/3.0.44?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/MSBuild.Sdk.Extras/1.6.68/3.0.44?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/MSBuild.Sdk.Extras/1.6.68/3.0.44?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>novotnyllc/MSBuildSdkExtras (MSBuild.Sdk.Extras)</summary> ### [`v3.0.44`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v3.0.44) #### Changes: - [#​281](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/281): don't disable built-in implicit defines - [#​276](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/276): Bump Nerdbank.GitVersioning from 3.4.231 to 3.4.244 - [#​278](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/278): Bump Microsoft.SourceLink.GitHub from 1.0.0 to 1.1.1 - [#​280](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/280): Update pipeline to use 6.0 sdk This list of changes was [auto generated](https://dev.azure.com/clairernovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=1848&\_a=release-summary). ### [`v3.0.38`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v3.0.38) #### Changes: - [#​265](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/265): Upgrade to GitHub-native Dependabot - [#​272](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/272): Bump Nerdbank.GitVersioning from 3.4.228 to 3.4.231 - [#​271](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/271): Bump Nerdbank.GitVersioning from 3.4.220 to 3.4.228 - [#​270](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/270): Bump Nerdbank.GitVersioning from 3.4.216 to 3.4.220 - [#​269](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/269): Bump Nerdbank.GitVersioning from 3.4.205 to 3.4.216 - [#​268](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/268): Bump Nerdbank.GitVersioning from 3.4.203 to 3.4.205 - [#​266](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/266): Bump Nerdbank.GitVersioning from 3.3.37 to 3.4.203 This list of changes was [auto generated](https://dev.azure.com/clairernovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=1832&\_a=release-summary). ### [`v3.0.22`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v3.0.22) #### Changes: - [#​248](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/248): Update site link - [#​251](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/251): Add support for the .NET 5 SDK - [#​243](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/243): Updated README.md with new release version - [#​239](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/239): Bump uwp meta package version from 6.2.9 to 6.2.10 - [#​234](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/234): Bump Nerdbank.GitVersioning from 3.1.91 to 3.2.31 This list of changes was [auto generated](https://dev.azure.com/clairernovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=1639&\_a=release-summary). ### [`v2.1.2`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v2.1.2) #### Changes: - [#​201](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/201): Fixed: WPF workaround for importing extensions does not always work - [#​233](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/233): Fix net5.0 TFM inference. - [#​228](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/228): Fully qualify metadata to avoid conflict between None and RidSpecificOutput - [#​226](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/226): Updated from stable to 2.0.85 and got a packing issue not finding RID - [#​218](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/218): Major per-RuntimeIdentifier build refactoring - [#​220](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/220): ci: Add validation for more macOS and netcore versions - [#​189](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/189): Use the `XAJavaInterop1` codegen by default - [#​196](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/196): Removed warning for building on Mac - [#​187](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/187): fix typo (FrameworName) This list of changes was [auto generated](https://dev.azure.com/clairernovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=1500&\_a=release-summary).</details> ### [`v2.0.54`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v2.0.54) #### Changes: - [#​186](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/186): Fix non-existing language targets restore - [#​185](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/185): Bump Nerdbank.GitVersioning from 3.0.25 to 3.0.26 This list of changes was [auto generated](https://dev.azure.com/onovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=1031&\_a=release-summary). ### [`v2.0.46`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v2.0.46) #### Changes: - [#​184](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/184): Fix WPF Regression [#​158](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/158) when .net-core 3.0 preview is not installed - [#​158](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/158): Regression for WPF projects in 2.0.24 This list of changes was [auto generated](https://dev.azure.com/onovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=990&\_a=release-summary). ### [`v2.0.43`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v2.0.43) #### Changes: - [`d2cb983`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/d2cb983f918c92c6d33862e544f5a5a14ba245b4) Merge pull request [#​183](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/183) from onovotny/uwp-updates \[ [#​182](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/182) ] - [`79ac352`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/79ac3528c61a56543dfafced137d1868f5784fe2) Updates to fix [#​182](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/182) This list of changes was [auto generated](https://dev.azure.com/onovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=969&\_a=release-summary). ### [`v2.0.41`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v2.0.41) #### Changes: - [`f1476ba`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/f1476ba441d9eacf4152ea04e5cc2e05b97ea6f8) whitespace - [`076bb48`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/076bb48a63ab477a776cc1f6f5edff3cecdf2a2c) whitespace - [`2cbc28a`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/2cbc28a1b278e90102e498927d7a66d77866e053) whitespace - [`a33d12c`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/a33d12c5a43782f3378fb347f71d8e613f6da038) whitespace - [`087e04b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/087e04bce64fe7aacf341e601f6ba70ede2204f5) whitespace - [`fa719e8`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/fa719e833cfbad8bf07c5877baf8360636ea01c1) whitespace - [`1a125ec`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/1a125ecd5441e789ca5c8ab551ccfeb154afcb82) whitespace - [`2092c74`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/2092c7473753e90bce6fb84e0dcc3ae7281793f2) whitespace - [`d94c7d3`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/d94c7d3e8568d74781dc76cce2ee82cf0c1161ff) whitespace - [`63f1122`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/63f112232abc9a53d227c0cc6f9db1801821d204) whitespace <details><summary><b>See more</b></summary> - [`759a3ef`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/759a3ef4460fa4ae26bad05416889d3135058b69) whitespace - [`6ebe3d3`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/6ebe3d3dd6e3b55c71a7f6292b9f885b49b32658) whitespace - [`9b17be8`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/9b17be832aeff3f31dd708325da8a5a2fd5ce1fe) whitespace - [`ce2ed19`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/ce2ed19fbc0e78ef80f52fddc414b875460fa317) whitespace - [`5448892`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/5448892c0be28cc2c799de4ee3375ec4c650ddbe) whitespace - [`05d042e`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/05d042e32138a36a5f1cf125d0be34d23196f22a) whitespace - [`921d47b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/921d47bcd0495f6aea37a2da3a7f5f0dc73a09fb) whitespace - [`6990cfb`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/6990cfb753c86ee27cda7bbd4dde844183c4623a) whitespace - [`ed365a7`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/ed365a7635edec48f03cd1a5bd644c40dd9150b2) whitespace - [`874de69`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/874de696ef60cec4e69c06e876fd2b6dc5a50f3a) whitespace - [`1a8c07e`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/1a8c07ef94f208486484f2728f674aebe0ab328a) whitespace - [`7f73bdc`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/7f73bdc8eacbe29575840ab513fac16c7d34feb4) whitespace - [`853f650`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/853f6500c1bcba74e64e6c538dc7ca7a8ff9e83b) Remove BOM - [`935c626`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/935c626bcd90d04e16ef16d6246fad18dc29bf49) Update nbgv - [`e21ad8b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/e21ad8b4d0f9cb38fd2a7015dc8a1b66c65642fe) Deafult DesignTimeBuild to false. \[ [#​173](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/173) ] - [`ede9692`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/ede9692eb71a2a35a0d9809626db680ec27ec982) Default AndroidUseIntermediateDesignerFile to true based on \[ [#​174](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/174) ] - [`3300481`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/3300481bde1432313bf641184dd4314bfae23573) doc comments - [`559855a`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/559855aa56b991f38ca115227596d6397f104a2f) Only check on lower msbuild versions \[ [#​179](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/179), [#​178](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/178) ] - [`8ce9859`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/8ce9859c2c32787ae2e626b616f00cbd9c3ccc50) Merge pull request [#​177](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/177) from mattleibow/patch-2 \[ [#​176](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/176) ] - [`bb2a609`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/bb2a609932c420aeb1ce2c75acb4cca780554c9c) fix whitespace - [`ae0e944`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/ae0e944d5813493020eeeaafc3c468ee9ba871c1) Native references can be used in non-binding projects - [`a20ddff`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/a20ddff453d32c768f6c8bb7b72d69599f5276a7) Added a test case that will fail when packing - [`a2dda44`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/a2dda447d67c2aff2796229546b740ea6a2a3304) Add a workaround for [#​176](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/176) This list of changes was [auto generated](https://dev.azure.com/onovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=943&\_a=release-summary).</details> ### [`v2.0.31`](https://togithub.com/novotnyllc/MSBuildSdkExtras/compare/2.0.29...2.0.31) [Compare Source](https://togithub.com/novotnyllc/MSBuildSdkExtras/compare/2.0.29...2.0.31) ### [`v2.0.29`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/2.0.29) https://github.com/onovotny/MSBuildSdkExtras/blob/master/README.md ### [`v2.0.24`](https://togithub.com/novotnyllc/MSBuildSdkExtras/releases/tag/v2.0.24) #### Changes: - [`61c157d`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/61c157d70e594a70539e9b18e814d4f4bd6a6fce) remove prerelease tag - [`edc3f03`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/edc3f039d232fb38a36f337a298c3bbff6d965a7) Merge pull request [#​156](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/156) from glennawatson/patch-1 - [`007d411`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/007d4112988ed08dfe30c993c6dc7658c1a43a44) Update to latest MsBuild.Sdk.Extras version. Add notes about .NET Core 3.0 - [`f88c2ca`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/f88c2ca69604e723d47adbeb94303866c4ab305d) Don't set MSBuildAllProjects for MSBuild >= 16. Older versions still get it. - [`7fafd17`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/7fafd17ee1b1c55768b2e01136bb2f3f17d53662) Use the 6.1.9 uwp package - [`b7e32a5`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/b7e32a5731ade351791776aae12058cef03a7243) Ensure inner builds batch \[ [#​154](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/154) ] - [`8cfb9cd`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/8cfb9cd75086419bae47e4cd736ea76cc4fe303b) Move implicit Windows SDK import later due to possible directory overriding - [`9f5da18`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/9f5da180519ca9e84bc595e2b66889575e87b93b) Add error message on missing windows sdk - [`3b76acb`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/3b76acb70640a7aef30fe417262a442a2a2d4eb4) Merge pull request [#​150](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/150) from KexyBiscuit/patch-1 \[ [#​149](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/149) ] - [`4583e8e`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/4583e8efd4f13aa618ed76dbdc7e40d1244b1611) Try fixing [#​149](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/149). <details><summary><b>See more</b></summary> - [`9d0ed92`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/9d0ed929a9a8e7fc9befc45585eb868b3c10fd67) \_SdkImplicitReference needs to be earlier - [`4cea3a6`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/4cea3a6bbbcf666c88ae564ae356838a147cb011) Ensure DIrectory.build.props affects defines - [`631ed4e`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/631ed4efa8823603e0698ad6305f4565aeda1b54) Move implicit reference to after lang targets since path can be affected by user settings - [`760c3b3`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/760c3b348941b8c193bd5293005dfc1d009cee05) Merge pull request [#​137](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/137) from mattleibow/patch-2 - [`39d7299`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/39d72995756cbd481498efc4c9710b137b48fbba) Prefix property with Extras - [`3372a52`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/3372a5212e3ce56040aafb818cbe4af3bf245c9a) Correctly select Windows.winmd on older SDKs - [`70e9db3`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/70e9db39b5c40abac186d529ffe7c58b83dbfeb4) Merge pull request [#​124](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/124) from DylanFPS/patch-1 - [`e5a8b39`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/e5a8b39d1572a12329ccfaaa3e5f225e5b0523af) Add deprecation warnings for legacy properties - [`22b9d65`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/22b9d6517667c88f44080eb88711f51f4c10cb16) Merge pull request [#​133](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/133) from onovotny/netcoreapp3-support - [`ce5eb36`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/ce5eb36a118f2b0868a39620f6bfc1455d6e97d4) Attach Windows.winmd to the tpv - [`14490f5`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/14490f5e28efd85e56f2c7ef87bc059728fb2ec6) Add test user control - [`30622e7`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/30622e784934d8f15fd24bd7f4ff7fdebd4d9daf) Direct reference - [`9a331e4`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/9a331e440387a9f4cd044d77f1265c6480558521) Remove support for PackageReference style. Needs Sdk= - [`d0877a6`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/d0877a6df6c9068faac109de53754ce85e6afed8) Bump version for netcore3 branch - [`c4704d6`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/c4704d6665cee6d3e0c59d18c4ddff3f1aa83052) Merge branch 'master' into netcoreapp3-support - [`d2b3c1c`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/d2b3c1c2f48c0ec3ac28732551b808fae17bf593) Bump implicit uwp package version - [`6303c93`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/6303c93cc90d5ca9bda90591a83a4661eec73c13) switch to sdk - [`2c6cc57`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/2c6cc57cf23fceab4137ca07b8fb6db47af0accf) allow creation of window - [`90fafab`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/90fafab5c41af0154b622ee7b5d43c3ec0948e12) remove extra gunk - [`0482dbe`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/0482dbe80a23682d9811dcdbc1a7e617c8dac8e7) Disable xaml targets when using WindowsDesktop sdk - [`1f8d843`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/1f8d843dc479fbf50d83eb8ee3ffc6bf42a5c9b8) Work in support for the WindowsDesktop SDK - [`0d79f51`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/0d79f51dc951b9fb0d9640079e622abc345ebb3e) Calculate base dir - [`cdd2840`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/cdd2840c74154c7890dcaed2da8f0d41157cba3d) Merge pull request [#​132](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/132) from WonyoungChoi/update_tizen_ver - [`ad08919`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/ad089191e9d28014ec5ff40dc7db60f0be82190a) Update implicit Tizen.NET version - [`25833a8`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/25833a88e6547cd48c8a4a03c89b8af8574000a9) Merge pull request [#​130](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/130) from SunburstApps/macos-support - [`962bc91`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/962bc916d16f300dc03574804e4cf7408a14814a) Add extra safety check - [`2edcc5f`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/2edcc5fe516c737abdd95b0c692b7502f5103cb5) Fixes to allow restore and build on macOS - [`4900b4f`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/4900b4f7b13eb876b6279f30c395295027af50d1) Update azure-pipelines.yml - [`5871af0`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/5871af083f00a460a1a504cf72ce4a965f23a29d) Merge pull request [#​128](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/128) from rainersigwald/master - [`bdb779b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/bdb779b3fe18136120cce1ab1e711ea651d0ed4a) Find C#/VB targets using MSBuildToolsVersion \[ [#​127](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/127), [icrosoft/msbuild#3778](https://togithub.com/icrosoft/msbuild/issues/3778) ] - [`490f99b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/490f99b0ed76d566f5de4f18f12182b17e97d920) Fix UWP packing bug - [`d48a2d3`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/d48a2d39feca6031b64f293ab3d47cf73bda4f5a) Revert - [`8813e58`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/8813e5806facbb6eec22148d00b1f6fe7dbfba3f) Update azure-pipelines.yml - [`c89485f`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/c89485f8a4e03fd430e7add2bb35faa0590a7efb) Merge branch 'master' into patch-1 - [`b49ec0b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/b49ec0bc6cfeebf89fb20203c3e23e39ed4a6779) Update azure-pipelines.yml - [`dfcf2a0`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/dfcf2a06248685e722bdc975ff2170035e186b0c) Update README.md - [`0d518ac`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/0d518aca85ef1a2e33792cd5be12f40561214b8a) Add details about JetBrains Rider - [`ec7134a`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/ec7134a92419bbed09fb6d2a889dfb4ebf2e561a) Update README.md - [`f943a8b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/f943a8b4f12bb8d1af2ac7bbdbd2141715b7e207) Merge pull request [#​120](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/120) from onovotny/rename - [`86b95d1`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/86b95d1872de5e27766abbe9f7343be72e68644b) rename file - [`1105b07`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/1105b0738b006c7b68fd3ea941c13c779ed8dbd7) Merge pull request [#​119](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/119) from onovotny/consolidate - [`c3814c8`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/c3814c867977fb5dfc81d85f6a8aeae32c333d3b) consolidate build files - [`8c1f923`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/8c1f923f96c2febdc826d37f1760cade2e1eb72c) Update README.md - [`1cd54c6`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/1cd54c6b8a7da4e7aab6a72794fc7f45089cf14f) Update README.md - [`9e8f6cc`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/9e8f6cc64133ebb4d2a40a3ce3f3e4165959df7d) Update .vsts-shared.yml - [`203103e`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/203103efa30a36510124d60c7580a07864adc178) Merge pull request [#​118](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/118) from onovotny/test - [`5575870`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/5575870ae07f22b7d5f5cc2eb174a41cf23648c1) build updates - [`365c527`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/365c527d48e95da381d0bb6fcdf14c45a9d4baa4) Ensure sdk props are imported before our props for legacy packageref \[ [#​114](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/114) ] - [`adfd0c3`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/adfd0c30ac95291ee89bba204796d5f3714eb108) Ensure we define a default GetPackagingOutputs since it always needs to be present. \[ [#​115](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/115) ] - [`1078189`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/1078189da32ae8f797135e37532bd5929e4b6e02) Ensure TPMV is set for Win8.x \[ [#​116](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/116) ] - [`49f432e`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/49f432e361fd7be2c839f1d4b81878a8d7a2718c) Ensure we conly import the portable targets once. \[ [#​105](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/105) ] - [`604c78a`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/604c78a7e9f78eef23304876e77fd33389839632) Ensure portable-tfm1+tfm2 are propertly escaped for defines. \[ [#​106](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/106) ] - [`ac93e0b`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/ac93e0b8ce57f239249ea47252d013dfeb612c73) Update UWP package - [`7f9df8e`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/7f9df8e63f5af4551789797807b6f67f05a09ca5) fix compare - [`9099675`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/9099675ebd5f674f3cbca50b0daa177c2f707c6a) Only none-include if default compile items are off - [`4d63077`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/4d63077d9e80f8e30b99a2c9915cfeecc32dc4be) Add workaround for [dotnet/sdk#2337 into the Extras - [`3646bf6`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/3646bf6f37348f9e4c1f40b7a3c78d16b4f569cb) Merge pull request [#​103](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/103) from onovotny/drafter - [`9534691`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/9534691d1e9855dc4a74a924088b742e78d6e868) add drafter config - [`3c7d67a`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/3c7d67aa687282e70f908f05d4c00c571a4b5958) Set as 1.7 - [`81ac7f6`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/81ac7f698500f4c1c4b62b018360ed740dddea46) Fix regression in NuGetTargetMoniker for Win8. Fixes [#​100](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/100) - [`2c1b2fe`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/2c1b2feadf7165c514f2506e3f7d66718d4812ad) Rename private var - [`d0e0fdd`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/d0e0fdd5801895b93e01efebd35ec2bc7ed0c7ff) Move to props - [`6ea905f`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/6ea905fdf47ac1710a567fc253a68b9ce6c50e2c) Merge pull request [#​99](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/99) from mattleibow/patch-2 - [`e657733`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/e657733d3f167238c2ea8cd29f61465be691ab6b) Add the missing "v" to <TargetFrameworkVersion> - [`f0bb2da`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/f0bb2da6f56cf5c0901d8ac145be3bbb293e930d) Merge pull request [#​96](https://togithub.com/novotnyllc/MSBuildSdkExtras/issues/96) from batzen/patch-1 - [`aa12aad`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/aa12aade4769107fda4a34a6bb8a505c031eb951) Fixing wrong resource include rule - [`2c592ed`](https://togithub.com/novotnyllc/MSBuildSdkExtras/commit/2c592ed7e9f3425e86775088feafecb4010870dc) fix for target that is only in .4xx This list of changes was [auto generated](https://dev.azure.com/onovotny/96789f1c-e804-4671-be78-d063a4eced9b/\_release?releaseId=702&\_a=release-summary).</details> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/reactiveui/ReactiveUI). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
From @onovotny on June 15, 2018 0:22
This is broken with 15.7.3 and 15.8.2 p2 with .NET Core 2.1 installed. It used to work. I think that setting
<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
changed the behavior where files used to be visible.The solution explorer is missing files that are specified by the include globs.
ProjectSystemRegression.zip
Note that the project builds correctly, but files aren't visible in VS.
A workaround requires adding
<None Include="**\*.cs" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
to the project file, but I don't believe that used to be necessary, thus the regression.Here's the csproj:
What's interesting here is that there's some dynamic evaluation happening. It's not just
*.shared.cs
that's visible, but it matches on the first conditional item group as well and shows*.netstandard.cs
. It does not show any of the subsequent ones though.@jamesmontemagno
Copied from original issue: dotnet/project-system#3652
The text was updated successfully, but these errors were encountered: