Skip to content

Latest commit

 

History

History
31 lines (16 loc) · 2.52 KB

contributing.md

File metadata and controls

31 lines (16 loc) · 2.52 KB

Contributing Guide

The primary focus of .NET Core 3.0 release for WPF is to achieve parity with .NET Framework. Priority will be given to changes that align with that goal. See the roadmap to understand project goals.

See the acceptance criteria for types of issues that will be accepted before General Availability of .NET Core 3.0.

Please file an issue for any larger change you would like to propose.

See Developer Guide to learn how to develop changes for this repo.

This project follows the general .NET Core Contribution Guidelines. The contribution bar from the general contribution guidelines is copied below.

Contribution "Bar"

Project maintainers will consider changes that improve the product or fix known bugs (please file issues to make bugs "known").

Maintainers will not merge changes that have narrowly-defined benefits due to compatibility risk or complexity added to the product. We may revert changes if they are found to be breaking.

Most .NET Core components are cross-platform and we appreciate contributions that either improve their feature set in a given environment or that add support for a new environment. We will typically not accept contributions that implement support for an OS-specific technolology on another operating system. We also do not intend to accept contributions that provide cross-platform implementations for Windows Forms or WPF.

Contributions must also satisfy the acceptance criteria to learn how to develop changes for this repo.as well as other published guidelines defined in this document.

Code Formatting Improvements and Minor Enhancements

We will consider code-formatting improvements that are identified by running code analyzers.

Our CodeAnalysis rules are not enabled by default. These can be enabled by setting the MSBuild property EnableAnalyzers=true (in commandline, it is set as /p:EnableAnalyzers=true).

The code analyzer would likely recommend changes that can result in changes to the generated IL. In general, we prefer code-formatting PR's to be limited to changes that do not have any impact on the IL - these are easier to review and approve and do not require additional testing.

Please open issues for changes that affect the IL or might require additional validation, and work with the project maintainers to determine whether a PR would be appropriate.