Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a dialect option to not normalise booleans #408

Open
1 task
jakeng-grabtaxi opened this issue Feb 15, 2024 · 0 comments
Open
1 task

Provide a dialect option to not normalise booleans #408

jakeng-grabtaxi opened this issue Feb 15, 2024 · 0 comments
Assignees

Comments

@jakeng-grabtaxi
Copy link

Thanks for this amazing library.

Is your feature request related to a problem? Please describe.
I am trying to use this library to generate queries for Presto/Trino SQL. It seems that Trino does not support using IS when comparing bools, = should be used instead. Currently, the normalisation is "hardcoded" in

func checkBoolExpType(op BooleanOperation, lhs Expression, rhs interface{}, invert bool) BooleanExpression {
.

Describe the solution you'd like
I think there should be some way to specify (maybe at the dialect level) whether bools should be normalised. What you think?

Dialect

  • trino/presto

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants