Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make private methods static where possible #475

Merged
merged 1 commit into from Aug 4, 2019

Conversation

gaul
Copy link
Contributor

@gaul gaul commented Jul 26, 2019

This avoids an unneeded object reference. Found via error-prone.

This avoids an unneeded object reference.  Found via error-prone.
@stleary
Copy link
Owner

stleary commented Jul 29, 2019

What problem does this code solve?
error-prone warnings

Risks
Changes to the API?
Will this require a new release?
Should the documentation be updated?
Does it break the unit tests?
Was any code refactored in this commit?
None/No

Review status
Approved Starting 3 day comment window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants