Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xml hex entity parse #542

Merged
merged 5 commits into from Jul 23, 2020
Merged

Conversation

johnjaylward
Copy link
Contributor

@johnjaylward johnjaylward commented Jul 20, 2020

fixes #537

What problem does this code solve?

Corrects bug in XML.unescape where it was incorrectly passing entities to be unescaped without lower-casing first as the tokener does internally. This corrects the issue at the tokener level by not requiring the entity to be lowercase before processing.

Risks

None. Bug fix

Changes to the API?

No

Will this require a new release?

Yes

Should the documentation be updated?

No need

Does it break the unit tests?

No. New unit tests have been added showing the tokener properly parsing, but the direct call failing, then succeeding after the code change

Was any code refactored in this commit?

Just some test calls to make error reporting easier to read:
changed some calls that looked like this:

// hard to read in error logs
assertTrue("some message", actual.equals(expected));

to

// easier to read in error logs
assertEquals("some message", expected, actual);

Review status
APPROVED

@stleary
Copy link
Owner

stleary commented Jul 20, 2020

Starting 3-day comment window.

@stleary stleary merged commit 8804021 into stleary:master Jul 23, 2020
@johnjaylward johnjaylward deleted the fixXmlHexEntityParse branch July 23, 2020 16:07
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue while converting xml to json
2 participants