JSONObject.similar() numeric compare bug fix #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjaylward
force-pushed
the
issue-616-similar-bug
branch
from
7cfa2c0
to
781af8e
Compare
johnjaylward
force-pushed
the
issue-616-similar-bug
branch
from
781af8e
to
579784d
Compare
|
Starting 3-day comment window. |
stleary
changed the title
stleary
changed the title
stleary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
JSONObject isSimilar() may fail when comparing decimal values. Fixes #616
Risks
Low
Changes to the API?
No change to the API. Internal behavior in the way that double values get created has changed, but in this case, it is considered worth the possible risk.
Will this require a new release?
Yes
Should the documentation be updated?
No
Does it break the unit tests?
No, New unit tests were added to show the bug.
Was any code refactored in this commit?
Several unrelated files in this commit contain minor documentation updates.
Review status
APPROVED