Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentityHashSet for JSONObject cycle detection #651

Merged
merged 1 commit into from Dec 4, 2021
Merged

IdentityHashSet for JSONObject cycle detection #651

merged 1 commit into from Dec 4, 2021

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Nov 27, 2021

Fixes #650

johnjaylward
johnjaylward approved these changes Nov 27, 2021
View reviewed changes
Copy link
Contributor

@johnjaylward johnjaylward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Thanks for fixing so fast.

@stleary stleary mentioned this pull request Dec 1, 2021
Closed
@stleary
Copy link
Owner

stleary commented Dec 1, 2021

What problem does this code solve?
Improves cycle detection for bean parsing by using a more suitable container for referenced objects.

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, new unit tests were added.

Was any code refactored in this commit?
No

Review status
APPROVED

@stleary
Copy link
Owner

stleary commented Dec 1, 2021

Starting 3 day comment window

@stleary stleary mentioned this pull request Dec 1, 2021
Closed
@stleary stleary merged commit 04e8ea8 into stleary:master Dec 4, 2021
@stleary stleary changed the title Use IdentityHashSet for cycle detection IdentityHashSet for JSONObject cycle detection Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjaylward johnjaylward johnjaylward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using IdentityHashSet for cycle detection
3 participants
@cushon @stleary @johnjaylward