Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: React 18 support? #560

Closed
vova42matters opened this issue Apr 18, 2022 · 14 comments · Fixed by #607
Closed

Feat: React 18 support? #560

vova42matters opened this issue Apr 18, 2022 · 14 comments · Fixed by #607
Labels

Comments

@vova42matters
Copy link

Is your feature request related to a problem? Please describe.
When using react@18.0.0 and running npm install, an error gets thrown.

Describe the solution you'd like
Just update peerDependencies and test out dropdown

Describe alternatives you've considered
Running npm config set legacy-peer-deps true solves the problem.

Additional context
Logs:

npm ERR! Found: react@18.0.0
npm ERR! node_modules/react
npm ERR!   react@"^18.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0 || ^17" from react-dropdown-tree-select@2.7.1
npm ERR! node_modules/react-dropdown-tree-select
npm ERR!   dev react-dropdown-tree-select@"2.7.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Using Node 16, npm 8.2.0

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 18, 2022
@mrchief mrchief removed the stale label May 19, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 18, 2022
@mrchief
Copy link
Collaborator

mrchief commented Jun 22, 2022

not stale

@stale stale bot removed the stale label Jun 22, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 22, 2022
@mrchief mrchief removed the stale label Jul 29, 2022
@erikmoren
Copy link

Hi, any progress with this ...?

@ldeveber
Copy link
Contributor

FWIW, we are using this with React 18 and have not seen any side effects (other than the usual warnings about componentWillReceiveProps)

@mrchief
Copy link
Collaborator

mrchief commented Aug 18, 2022

Does anyone care to send a PR? Should be a quick one

@apaschenko-amplify
Copy link

Probably something has to be done with enzyme tests as a part of this migration. As enzymejs/enzyme#2524 suggests, enzyme is not going to support React 18 in the near future.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@moxxuk
Copy link

moxxuk commented Nov 1, 2022

This is not completed

@mrchief mrchief reopened this Nov 10, 2022
@stale stale bot removed the stale label Nov 10, 2022
@pckilgore
Copy link
Contributor

I believe npx react-codemod rename-unsafe-lifecycles should work to do this in the short term, but requires a dependency update to react 16.3+

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 6, 2023
@pckilgore
Copy link
Contributor

I submitted a pr to fix this recently.

@stale stale bot removed the stale label Jan 7, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants