Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Long-Term Plan] Moving Forward with the React Hooks API #1233

Open
1 of 9 tasks
silviuaavram opened this issue Feb 9, 2021 · 5 comments
Open
1 of 9 tasks

[Long-Term Plan] Moving Forward with the React Hooks API #1233

silviuaavram opened this issue Feb 9, 2021 · 5 comments

Comments

@silviuaavram
Copy link
Collaborator

silviuaavram commented Feb 9, 2021

Problem description:

Medium Term Plan

This should be our 6-12 month development plan for downshift-js. I think its API is a great success in providing accessibility and functionality to React Components. We should continue to improve the library in terms of bugfixes, types and features:

  • Migrate hooks API to Typescript.
  • Mark <Downshift> as deprecated.
  • Remove <Downshift>.
  • Create useTagList to replace useMultipleSelection.
  • Create useMultipleSelect and useMultipleCombobox for better usage experience. Should be based on useSelect, useCombobox and useTaglist.
  • Deprecate useMultipleSelection.
  • Remove useMultipleSelection.
  • Implement hooks for other components using a similar API. Suggestions: useCarousel, useTree, useMenu. Submit your proposals.
  • Migrate useCombobox to ARIA 1.2 specification. Remove getComboboxProps. Update examples.

Comments

It's not definitive so I am looking for feedback in terms of prioritisation and features.

@tonypee
Copy link

tonypee commented Feb 16, 2021

using the * as xxx syntax makes it harder for autocompletion of imports no? would import { useSelect } be possible?

@silviuaavram
Copy link
Collaborator Author

It could, sure @tonypee . I wasn't aware of that, it makes sense. Thanks for the feedback!

@silviuaavram silviuaavram changed the title [RFC] Moving Forward with React Hooks [Mid-Term Plan] Moving Forward with the React Hooks API Apr 5, 2021
@silviuaavram
Copy link
Collaborator Author

So far, we have migrated to ARIA 1.2.

@silviuaavram silviuaavram changed the title [Mid-Term Plan] Moving Forward with the React Hooks API [Long-Term Plan] Moving Forward with the React Hooks API Dec 17, 2022
@silviuaavram silviuaavram mentioned this issue Dec 19, 2022
Closed
10 tasks
@drewbrend
Copy link
Contributor

Create useMultipleSelect and useMultipleCombobox for better usage experience. Should be based on useSelect, useCombobox and useTaglist.

+1 for this. In our design system we use downshift's hooks and found we needed to combine the multi selection hook with the relevant select/combobox hook to improve usability for our consumers. We expose the equivalent of:

  • useSelect
  • useCombobox
  • useMultipleSelect
  • useMultipleCombobox

Is this going to make it into v8? with some other the other v8 changes we might be able to greatly simplify our implementation. 🤞

@silviuaavram
Copy link
Collaborator Author

V8 has enough changes as it is, it's going to be released with the current ones and we can create another major release with the new hooks. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants