Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected item is not updated in mobile devices #1554

Open
RohitHF opened this issue Oct 24, 2023 · 5 comments
Open

Selected item is not updated in mobile devices #1554

RohitHF opened this issue Oct 24, 2023 · 5 comments
Labels

Comments

@RohitHF
Copy link

RohitHF commented Oct 24, 2023

  • downshift version: 7.6.0
  • node version: v18.17.1
  • npm (or yarn) version:3.5.1

Relevant code or config
https://www.downshift-js.com/use-select/#basic-multiple-selection

What you did:
Tested the example in iPhone ios v16+
What happened:
The selection is not updated on clicking outside to close the dropdown select. It works fine if we toggle without clicking outside

Reproduction repository:

Problem description:
The mobile devices do not get the correct selected items on clicking outside. Attached video

Suggested solution:
If we can disable the closing of select dropdown on clicking outside, we can use this in touch devices.

Dropdown.with.multiselect.bug.in.native.device.MP4
@silviuaavram
Copy link
Collaborator

You can also disable selection on button blur. It's unfortunate that it has to be done in order to avoid this behaviour on mobile.

@silviuaavram
Copy link
Collaborator

This will require a change and a fix on our side as well. Will update once they are done.

@RohitHF
Copy link
Author

RohitHF commented Feb 22, 2024

Thanks for the update @silviuaavram . Is there any ETA on this?

@silviuaavram
Copy link
Collaborator

@RohitHF Could you give me again a few more details related to repro steps, actual behaviour and expected behaviour?

After looking at the docs example, it seems to me that the mobile behaviour is the same as the desktop one.

@silviuaavram
Copy link
Collaborator

Actually, I think the behaviour is consistent. If you have a highlighted item and you blur, it will get selected on both mobile and web. The actual problem is the different behaviour between select and combobox. I have opened an issue on ARIA, we will update our hooks as they suggest.

w3c/aria-practices#2966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants