Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useSelect): correct getLabelProps return type #1562

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Dec 29, 2023

What:
FIx a type change from #1561.

Why:
The type change was meant to be on the returned value, not the props

How:

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53dd723) 100.00% compared to head (2bed743) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1562   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1738      1738           
  Branches       522       522           
=========================================
  Hits          1738      1738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silviuaavram silviuaavram merged commit a5d6310 into master Dec 29, 2023
2 checks passed
@silviuaavram silviuaavram deleted the type/fix-label-props-type branch December 29, 2023 14:05
Copy link

🎉 This PR is included in version 8.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants