Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: lazily create ureq agents #836

Merged
merged 1 commit into from Apr 5, 2024
Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Apr 5, 2024

I actually did a flamegraph on Mac. I didn't notice it was slow because I use Windows, which was way faster at this.

Before:

% time dprint check --incremental=false ./data/package-template.json
0.10s user 0.02s system 65% cpu 0.173 total

After:

% time ../dprint/target/release/dprint check --incremental=false ./data/package-template.json
0.01s user 0.01s system 67% cpu 0.023 total

@dsherret dsherret merged commit 426d59a into main Apr 5, 2024
9 checks passed
@dsherret dsherret deleted the perf_lazily_create_ureq_agents branch April 5, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant