Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Dr4ft failed to enforce correct # of picks/burns #1511

Open
LotusWalker opened this issue Mar 31, 2021 · 9 comments
Open

Bug: Dr4ft failed to enforce correct # of picks/burns #1511

LotusWalker opened this issue Mar 31, 2021 · 9 comments
Labels

Comments

@LotusWalker
Copy link

Drafted for the first time in awhile on Dr4ft.info using Chrome, and unfortunately ran into a bug in Pack 8. I tried to make a selection and Dr4ft skipped to the next pick before I had finished. When that pack came back I saw that it had one too many cards, and so I believe it burned 2 but didn't give me a pick. At the end of the draft I had 39 cards, a friend had 41 cards, and another friend had the correct 40 cards.

Have done 30-40 drafts in Jan/Feb using this configuration and never ran into a problem, so I think this is likely a bug introduced at some point in March. Not positive about that though, just speculation.

Draft Options: Glimpse Draft, 3 Players, Cube, 8 Packs, 15 Cards/Pack, 1 Pick/Pack, 2 Burns/Pack

@LotusWalker
Copy link
Author

One of the drafters remembers changing his burns several times right before the bug happened, so perhaps that somehow caused the glitch..?

@tooomm
Copy link
Contributor

tooomm commented Mar 31, 2021

Do you recall the game ID or the time when this happened?

@LotusWalker
Copy link
Author

@tooomm Sure, Event#: 2f96b260-91b7-11eb-9e4a-8bb42ba95a8b

Time: 20210331_005640

@mixmix
Copy link
Member

mixmix commented Apr 1, 2021

It could be an incorrect triggering of the "confirm" like if you click on a burn and click it again as burn.

Alternatively a timeout on the selection which failed to auto select?

Would have to get in and check all the logic...

@Celereon
Copy link

Celereon commented Jun 12, 2021

I think I had the same issue last night, we had to end two drafts prematurely because one player had 1 card left and needed 2 (pick 1 burn 1) so they couldn't hit confirm to move on. It was a cube draft, p1b1, 18 cards/pack, 4 players (no bots). The first draft had 5 packs and the second draft had 4 packs. I think these are the game IDs:
630a7230-ca9c-11eb-aa0b-e532a72b0155
c2576e60-caa0-11eb-aa0b-e532a72b0155

Edit: There was no time limit set on either.

@LotusWalker
Copy link
Author

@Celereon Thanks for reporting. Did you notice anything odd that might have triggered the bug? We’re having trouble identifying what is causing it. It happened in my drafts when one player changed his picks/burns quickly in rapid succession, but not really sure if that’s the trigger.

@mixmix
Copy link
Member

mixmix commented Jun 12, 2021

@ZeldaZach is there any data you can / should pull before logs are lost from those games?

@Celereon
Copy link

@LotusWalker I thought it might be the double-faced cards, or if someone double-clicked a pick/burn symbol to auto-confirm with pick & burn already highlighted (this caught us out once or twice but I think it's intended behaviour). But I ran essentially the same cube with another player the previous night (2 players, p1/b2) and it ran fine.

It was the same player both times that ended up with only one card and couldn't proceed. They'd had earlier issues on a different computer with the pick and burn symbols not appearing, but switched to a laptop so this might be unrelated. It was pack 1 of 5 in the first game and pack 4 of 4 in the second game.

@LotusWalker
Copy link
Author

@Celereon Thanks for the report…this is a tough one to nail down. One thing to consider, in my drafts it didn’t seem like the player that ended up with the odd card in the pack at the end had caused the bug. In ours, it seemed like the player who acted before that player actually caused the issue…but too small of a sample size to know for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants