Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run heavy tasks in DrasylServerChannel's EventLoop #636

Open
HeikoBornholdt opened this issue Apr 1, 2024 · 2 comments
Open

Do not run heavy tasks in DrasylServerChannel's EventLoop #636

HeikoBornholdt opened this issue Apr 1, 2024 · 2 comments
Labels
performance

Comments

@HeikoBornholdt
Copy link
Member

We have handlers like LocalHostDiscovery and InternetDiscoveryChildrenHandler that perform "heavy" tasks (read from/write to file system, DNS lookups, etc.). Such heavy tasks negatively affect the performance of the DrasylServerChannel as no messages can be processed in the meantime.

We should stop letting these heavy tasks be performed in the channel EventLoop.
@HeikoBornholdt
Copy link
Member Author

@KevinRoebert thoughts on this?

@HeikoBornholdt
Copy link
Member Author

FYI: The negative effects on performance by this were significantly mitigated by #652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HeikoBornholdt