Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to deploy to lagoon due to false-positive docker-compose.yml validation #1084

Open
AlexSkrypnyk opened this issue Nov 3, 2023 · 1 comment
Assignees
Labels
BLOCKED Issue or pull request is blocked State: Confirmed The issue was triaged and confirmed for development Type: Defect Issue is a defect UPSTREAM Issue or pull request is related to an upstream project
Milestone

Comments

@AlexSkrypnyk
Copy link
Member

Fails on

DREVOPS_LOCALDEV_URL: &default-url ${DREVOPS_LOCALDEV_URL:-${COMPOSE_PROJECT_NAME:-example-site}.docker.amazee.io}

uselagoon/build-deploy-tool#252

Temp workaround:
Replace with

DREVOPS_LOCALDEV_URL: &default-url ${COMPOSE_PROJECT_NAME:-example-site}.docker.amazee.io
@AlexSkrypnyk AlexSkrypnyk added Type: Defect Issue is a defect UPSTREAM Issue or pull request is related to an upstream project labels Nov 3, 2023
@AlexSkrypnyk AlexSkrypnyk added this to the 1.19 milestone Jan 2, 2024
@AlexSkrypnyk AlexSkrypnyk added the BLOCKED Issue or pull request is blocked label Jan 22, 2024
@AlexSkrypnyk
Copy link
Member Author

While we are blocked on the upstream, in order to unblock the users, the false-positive breaking code was removed in #1150

This PR would need to be reverted once this issue is resolved upstream.

@AlexSkrypnyk AlexSkrypnyk self-assigned this Jan 22, 2024
@AlexSkrypnyk AlexSkrypnyk modified the milestones: 1.19, 1.20, 1.21 Feb 15, 2024
@AlexSkrypnyk AlexSkrypnyk modified the milestones: 1.20, 1.21 Feb 28, 2024
@AlexSkrypnyk AlexSkrypnyk added the State: Confirmed The issue was triaged and confirmed for development label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED Issue or pull request is blocked State: Confirmed The issue was triaged and confirmed for development Type: Defect Issue is a defect UPSTREAM Issue or pull request is related to an upstream project
Projects
Status: Next release
Development

No branches or pull requests

1 participant