Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility range parameter names error #23

Open
redfiretim opened this issue Jul 8, 2020 · 1 comment
Open

accessibility range parameter names error #23

redfiretim opened this issue Jul 8, 2020 · 1 comment

Comments

@redfiretim
Copy link

Hi, I noticed that the range parameter names for accessibility are wrong way around.
It conflicts with the statements in the documentation that zero is MOST accessible."

"accessibility
A factor describing how possible an event is to do with zero being the most accessible
[0.0, 1.0]"

You can check it when using only 1 of the range parameters.
"MAXaccessibility"is actually the MINIMUM value up until zero (0).
and "MINaccessibility"is actually the MAXIMUM value up from one (1).

You wouldn't notice this when using both MINaccessibility and MAXaccessibility in one request, because then they are interchangeable.

Please ccorrect this issue.
(And notify my, because I now changed my frond-end to work with the reversed order)

Thanks.

@drewthoennes
Copy link
Owner

Hi @redfiretim, thanks for your interest in the project! This is an issue that was noted in a previous issue, it just hasn't been top priority as efforts have instead been focused on developing a v2 API and rewriting the entire frontend.

This shouldn't be a difficult fix and I can definitely look at it when I get a chance, but it might be a bit before I can due to how busy I am with my other commitments. Feel free to submit a PR if time is of the essence and I'd be appreciative and more than willing to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants