Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use continueAfterTimeout for Aurora DDL statements #11

Open
marvinpinto opened this issue Apr 7, 2020 · 1 comment
Open

Use continueAfterTimeout for Aurora DDL statements #11

marvinpinto opened this issue Apr 7, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@marvinpinto
Copy link

First off thank you for this excellent library - it has been immensely helpful to me!

Would you be open to adding the continueAfterTimeout parameter as one of the arguments to the executeStatement request? (likely in here)

The AWS SDK docs recommend enabling the continueAfterTimeout flag to continue running DDL statements after a call times out.

If you're concerned about a breaking change, you could add it to the params list disabled by default, and then expose it as a config option.

Thanks again for this library!

@jaredready
Copy link
Contributor

I think this sounds like a great change. It may be a few days until we get to this, though. Please feel free to submit a PR if you're needing this change sooner.

Thanks for the recommendation!

@theBenForce theBenForce self-assigned this Apr 14, 2020
@theBenForce theBenForce added enhancement New feature or request good first issue Good for newcomers labels Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants