New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

driver.close does not call the provided callback #19

Open

ornoone opened this issue Sep 7, 2021 · 0 comments

ornoone commented Sep 7, 2021 •

edited

a difference between your driver and others is that no callback is ever caller after all migrations is applied:

DBMigrate.getInstance(true,{})
    .sync()
    .then(() =>console.log('migration done'))
    .catch((err) => console.log('migration failed', err))

will never have his then or catch called

I found that the source of this problem is that you never call the provided callback during driver.close(cb);

this callback is responsible for terminating the promise of all operations. (see db-migrate/lib/commands/on-complete.js:11)

do you still maintains this repository, and if so, would you merge a PR that fix this bug if I fill one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment