Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for endpoint in rdsParams #3

Open
creatorrr opened this issue May 3, 2020 · 1 comment
Open

Support for endpoint in rdsParams #3

creatorrr opened this issue May 3, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@creatorrr
Copy link

Hi! I use the serverless framework and its plugin data-api-local-serverless for local development. The plugin generates starts a mock data-api service on a local endpoint.

At the moment, this package doesn't support setting a custom endpoint on the RDSDataService instance (see here). Please consider adding support for it? I'm happy to submit a PR.

@theBenForce
Copy link

Sounds like a good feature @creatorrr, if you create a PR I'll make sure it gets in.

@theBenForce theBenForce added enhancement New feature or request good first issue Good for newcomers labels May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants