Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[downgrade] quoted keys breaks conversion #169

Open
jimsheldon opened this issue Aug 17, 2023 · 1 comment
Open

[downgrade] quoted keys breaks conversion #169

jimsheldon opened this issue Aug 17, 2023 · 1 comment
Labels
bug Something isn't working downgrade

Comments

@jimsheldon
Copy link
Collaborator

Here is a v1 pipeline with a quoted key (to make sure on is treated as a string rather than a boolean)

stages:
- name: test
  spec:
    steps:
    - name: job1
      "on":
        failure:
          errors:
          - all
          type: ignore
      spec:
        run: execute_script_1
      type: script
  type: ci
version: 1

Currently this fails to downgrade

2023/08/16 10:14:24 unexpected end of JSON input

Removing the double quotes around on converts successfully.

downgrade needs to allow for keys that are in double quotes.

@jimsheldon jimsheldon added bug Something isn't working downgrade labels Aug 17, 2023
@jimsheldon
Copy link
Collaborator Author

Fix in #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working downgrade
Projects
None yet
Development

No branches or pull requests

1 participant