Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloudbuild] support for steps[*].allowFailure #62

Open
bradrydzewski opened this issue Mar 29, 2023 · 1 comment
Open

[cloudbuild] support for steps[*].allowFailure #62

bradrydzewski opened this issue Mar 29, 2023 · 1 comment
Labels
cloudbuild Google Cloud Build conversion target downgrade

Comments

@bradrydzewski
Copy link
Member

bradrydzewski commented Mar 29, 2023

https://cloud.google.com/build/docs/build-config-file-schema#allowfailure

In a build step, if you set the value of the allowFailure field to true, and the build step fails, then the build succeeds as long as all other build steps in that build succeed.

steps:
- name: 'ubuntu'
 args: ['-c', 'exit 1']
 allowFailure: true
steps:
- name: 'ubuntu'
 args: ['echo', 'Hello World']

This is supported in the v0 yaml so we just need to add the mapping.

                  failureStrategies:
                    - onFailure:
                        errors:
                          - AllErrors
                        action:
                          type: Ignore

Update added support for allowFailure; need to add downgrade logic

@bradrydzewski bradrydzewski added gap Harness product gap cloudbuild Google Cloud Build conversion target enhancement New feature or request and removed gap Harness product gap labels Mar 29, 2023
@bradrydzewski
Copy link
Member Author

mapped to v1 failure strategies. the downgrade mapping is not yet complete, though
https://github.com/drone/go-convert/blob/fa88d1e840237b74941669da12af6d5692a473c4/convert/cloudbuild/convert.go#L311:L323

@bradrydzewski bradrydzewski added downgrade and removed enhancement New feature or request labels Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloudbuild Google Cloud Build conversion target downgrade
Projects
None yet
Development

No branches or pull requests

1 participant