Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access to RedisClusterClient/RedisClient #51

Open
jmhodges opened this issue Aug 19, 2020 · 4 comments
Open

access to RedisClusterClient/RedisClient #51

jmhodges opened this issue Aug 19, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jmhodges
Copy link

I was trying to use this wonderful library but the app I'm working on needs access to the underlying RedisClusterClient in order to handle connection pooling. I can see that there's lots of useful things done with the StatefulRedisClusterConnection before it's returned, so I understand that this is possibly outside the scope of the project.

But it would be nice to get all this great JSON config work while will getting the Client I needed.

@natalie-zamani
Copy link
Member

natalie-zamani commented Aug 19, 2020

Hi @jmhodges! Thanks for the kind words! 😃

When in the lifecycle of the client setup would you need access to the RedisClusterClient? If we added a way to override the existing factory and plug your functionality in, would that meet your needs?

@jmhodges
Copy link
Author

jmhodges commented Sep 18, 2020

Oh, lemme narrow the focus to RedisClient and let's ignore the "connection pooling" stuff, because I was still learning a legacy codebase this is going in:

We want to get access to pubsub stuff with redisClient.connectPubSub and MasterClient.connect(redisClient, ...)

@natalie-zamani natalie-zamani added the enhancement New feature or request label Nov 18, 2020
@natalie-zamani
Copy link
Member

natalie-zamani commented Nov 18, 2020

@jmhodges That seems totally reasonable! One way this can be easily addressed is by adding a protected method that will allow you to extend RedisClusterClientFactory/RedisClientFactory and add whatever logic you need to perform on the RedisClient.

One follow-up question: do you simply need to configure additional things on the RedisClient, or do you actually need to be given the client itself to use in your application logic?

@JKomoroski
Copy link

Not sure if directly related, but I too was hoping to use this for Pub/Sub.

@joschi joschi added the good first issue Good for newcomers label May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants