Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstrumentedExecutorService does not remove registered gauges after shutdown #2920

Closed
nicu-da opened this issue Oct 11, 2022 · 3 comments · May be fixed by #3202
Closed

InstrumentedExecutorService does not remove registered gauges after shutdown #2920

nicu-da opened this issue Oct 11, 2022 · 3 comments · May be fixed by #3202
Labels
Stale

Comments

@nicu-da
Copy link

nicu-da commented Oct 11, 2022 •
edited

Similar to #1684.

As the gauges are not removed, once we shutdown the executor service and try to start again with the same name, the executor service can no longer be started.
@joschi
Copy link
Member

joschi commented Oct 11, 2022

Do you have this issue only in tests or also in production?

If the latter, could you please describe the use case?

@nicu-da
Copy link
Author

nicu-da commented Oct 11, 2022

The issue would also happen in production.
The use-case is caused by having multiple components started within the same java process. As part of specific failure handlers a component can be restarted. As the component itself manages the executor services it uses, this also entails stopping the current execution services and starting them again, using the same name. This in turn is impossible to do because the gauges added as part of #1928 are never removed when the executor service is stopped.

@nicu-da nicu-da mentioned this issue Oct 12, 2022
Merged
@the-thing the-thing mentioned this issue Feb 22, 2023
Open
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove the "stale" label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Apr 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

InstrumentedExecutorService registered metrics cleanup after shutdown the-thing/metrics
2 participants
@joschi @nicu-da