New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoughts on improving visibility to SettableGauge #3351

Open

dennyac opened this issue May 12, 2023 · 0 comments

Contributor

dennyac commented May 12, 2023

Been a dropwizard/metrics user since 2015, but just recently came across SettableGauge. Some thoughts on improving visibility usage

Add more documentation
Add a getter metricRegistry.settableGauge ( Currently I have to cast Gauge to SettableGauge to be able to set a value)
Add a default implementation for setValue to the Gauge interface that doesn't do anything to make it backwards compatible with Gauge implementations outside the dropwizard repository (May not be ideal ? Defeats purpose of SettableGauge interface?)

Happy to work on this if people find it useful

The text was updated successfully, but these errors were encountered:

github-actions bot added the Stale label

github-actions bot closed this as not planned

joschi removed the Stale label

joschi reopened this

dropwizard deleted a comment from github-actions bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment