Add a more type safe way of registering gauges #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arteam
force-pushed
the
safe-gauges
branch
2 times, most recently
from
be7c548
to
42326a9
Compare
|
@arteam Anything you want to polish/improve in this pull request? Happy to merge it otherwise. 😃 |
|
@joschi I think it should be good to go 👍 |
|
SonarCloud Quality Gate failed. |
dongjoon-hyun
pushed a commit
to apache/spark
that referenced
this pull request
Aug 3, 2022
### What changes were proposed in this pull request? This pr upgrade dropwizard metrics from 4.2.7 to 4.2.10 and changes the links [http://metrics.dropwizard.io/4.2.0](http://metrics.dropwizard.io/4.2.0) in `docs/monitoring.md` to [https://metrics.dropwizard.io/4.2.0](https://metrics.dropwizard.io/4.2.0) ### Why are the changes needed? There are 3 versions after 4.2.7, the release notes as follows: - https://github.com/dropwizard/metrics/releases/tag/v4.2.8 - https://github.com/dropwizard/metrics/releases/tag/v4.2.9 - https://github.com/dropwizard/metrics/releases/tag/v4.2.10 The new version brings a new API for more type safe of registering gauges(dropwizard/metrics#2642) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes #37372 from LuciferYang/dropwizard-4210. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
joschi
pushed a commit
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
registerGaugemethod toMetricRegistrythat acceptsGauge<T>instead ofMetricwhich makes it possible to register a gauge as a lambda expression without declaring its type explicetly.