Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 2.0.0 to NPM #39

Closed
doughsay opened this issue Jun 13, 2017 · 5 comments
Closed

Publish 2.0.0 to NPM #39

doughsay opened this issue Jun 13, 2017 · 5 comments

Comments

@doughsay
Copy link

The 16 basic ansi colors can be open to interpretation, many themes exist out there defining what the colors look like, so having the use_classes option is great for that.

But the 256 color palette and true-color aren't really open for interpretation, they are exact color specifications. I was wondering if we could add an option to allow for using classes for the basic 16 colors, but when rendering 256 or true-color, use inline styles.

Right now, if you use_classes and render 256 color, it renders a class, which could theoretically be used to build a stylesheet for all 256 colors (but that would be tedious). But for true-color, it only adds a data- attribute, which would mean I'd need to add an extra js library of some sort to actually apply the color. Seems like ansi_up could do that for me instead, right?

@doughsay
Copy link
Author

So I just noticed that the latest version (2.0.0) actually already does this! But it's not published to NPM... :( So I'm changing my issue to be a request to publish the latest version to NPM. Thanks!

@doughsay doughsay changed the title True-color and 256 color should (optionally) inline styles Publish 2.0.0 to NPM Jun 13, 2017
@drudru
Copy link
Owner

drudru commented Jun 15, 2017

Hi doughsay - I will get this pushed next week. Thank you.

@doughsay
Copy link
Author

doughsay commented Jun 15, 2017 via email

@drudru
Copy link
Owner

drudru commented Jun 21, 2017

Ok - npm pushed

@drudru drudru closed this as completed Jun 21, 2017
@doughsay
Copy link
Author

@drudru thanks! have you had a chance to take a look at #41 yet? I still can't use 2.0.0 directly, I'm still using my fork because of that one issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants