Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service annotations are not getting applied during service creation #292

Open
blockcoder1 opened this issue Jun 14, 2022 · 2 comments
Open

Comments

@blockcoder1
Copy link

blockcoder1 commented Jun 14, 2022

Hello Team,

We have a requirement when in we have to add Prometheus related annotations inside service metadata. Due to some reason this configurations are not getting reflected. Inside druid CR we have provision to provide annotations for our service

      services:
        - metadata:
            annotations:
              prometheus.io/scrape: "true"
              prometheus.io/port: "8092"
              prometheus.io/path: <Path>

I think this is not handled inside code. Any help is highly appreciated.

@AdheipSingh
Copy link
Contributor

@blockcoder1 yeah service annotations isnt being added by the operator.

We can add this in the makeService(). Feel free to send a PR.

@blockcoder1
Copy link
Author

@AdheipSingh sure will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants