-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum-stability to "stable" #266
Comments
This should not happen we use |
I think they fixed superfish module now but I will try to publish a dummy library to reproduce this. Anyway that problem is not the main reason for this change. Is about making dev,beta, alpha and rc dependencies more explicit instead of saying pick any stability but prefer stable. I feel we also get a speed improvement since less releases are scanned. |
+1 on this. It's safer and faster to specify the stability on a per package level. |
With drupal console stable now the template doesn't even has to specify any stability. We can add devel as an example that is going to need a @rc tag if |
Seems like core is grappling with this at the moment too: |
Core indeed moved to stable now (9.1.0). The change record contains a lot of good arguments to do the same. Then the README needs to be updated to explain how to properly require unstable releases. |
I'm on board with this too now, you can be explicit about your @dev if you need the unstable. |
As per D9 change record:
Having I suggest we do 2 things:
|
+1 on both points. |
I moved to |
Currently minimum-stability is set to "dev".
I think we should rely on composer defaults and have the minimum stability set to "stable" just by removing that line.
https://getcomposer.org/doc/04-schema.md#minimum-stability
Then we will need to add dev, alpha, beta, RC suffixes to the specific dependencies that need it like for example devel or drupal console.
https://getcomposer.org/doc/04-schema.md#package-links
The composer.json get also more semantic.
This way we don't hide dependencies on modules, libraries, etc that are not so mature.
This all started for me because there is a contrib module with a broken HEAD
https://www.drupal.org/node/2872222
What do you think?
The text was updated successfully, but these errors were encountered: