ArchiveRestoreCommands::importDatabase problem with DB drop or create logic

[Sweetchuck]

Describe the bug
ArchiveRestoreCommands::importDatabase()
https://github.com/drush-ops/drush/blob/12.x/src/Commands/core/ArchiveRestoreCommands.php#L576

It tries to ensure that the database is exists and it is empty.

        if ($isDbExist && !$sql->drop($sql->listTablesQuoted())) {
            throw new Exception(
                dt('Failed to drop database !database.', ['!database' => $databaseSpec['database']])
            );
        } elseif (!$sql->createdb(true)) {
            throw new Exception(
                dt('Failed to create database !database.', ['!database' => $databaseSpec['database']])
            );
        }

I think the problem with the code above is that:

1. in case of $isDbExists === true
2. then it tries to drop all the tables in the database
3. if the $sql->drop() is also successful, that means the overall if () is false
4. then it goes to elseif (!$sql->createdb(true))
5. which will always fail: "database cannot be created, because it is already exists".

Actual behavior
Wrong exception with misleading error message.

Workaround

        if ($isDbExist && !$sql->drop($sql->listTablesQuoted())) {
            throw new Exception(
                dt('Failed to drop database !database.', ['!database' => $databaseSpec['database']])
            );
        }

        if (!$isDbExist && !$sql->createdb(true)) {
            throw new Exception(
                dt('Failed to create database !database.', ['!database' => $databaseSpec['database']])
            );
        }

System Configuration

Q	A
Drush version?	11.x
Drupal version?	10.x
PHP version	8.1
OS?	Linux
DB engine	PostgreSQL 15.3