Fixes #5761 Get the relative path to the project root as the descript… #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… description says not the drush base path
|
Fixes #5761 |
|
Hoping @greg-1-anderson can take a look. |
greg-1-anderson
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
I'd have to check to see how drush.base-dir is calculated if you want a full comparison, but runtime.project is taken from Composer, and is literally what is wanted here, so I think this is a much better config variable to use here. And the tests pass, so ship it.
weitzman
added a commit
to weitzman/drush
that referenced
this pull request
Oct 26, 2023
The Doxygen misled us in drush-ops#5785. We want Drupal root and not project root as base path. Use DrupalFinder to get that.
weitzman
added a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the relative path to the project root as the docblock says not the drush base path.
This works for me but I'm not sure if the runtime.project is the correct config to use or if there is a better way? It seems like the drush.base-dir is not the correct config though and it's broken for my remote alias commands.