DrupalFinder drush replacement PR did not fully replaced it in Preflight

[AlexSkrypnyk]

Describe the bug
This PR replaced the DrupalFinder with DrushDrupalFinder in 12.x.

However, the Preflight.php still uses DrupalFinder:

$localAliasDrupalFinder = new DrupalFinder($this->environment());

Judging by the passed argument, this should have been DrushDrupalFinder.

This works on sites with the DrupalFinder because the current version 1.2 does not have a constructor. I caught this because I'm using the dev version of the DrupalFinder and it has a constructor incompatible with the code above.

Drush 13.x does not have this issue.

System Configuration

Q	A
Drush version?	12.x
Drupal version?	10.2
PHP version	8.2
OS?	Mac/Linux

[AlexSkrypnyk]

To solve this, either need to replace

$localAliasDrupalFinder = new DrupalFinder($this->environment());

with

$localAliasDrupalFinder = new DrupalFinder($this->environment()->cwd());

to make it compatible with the future versions of the DrupalFinder's constructor.

OR

Remove the DrupalFinder reference from the preflight altogether as it is done in 13.x.

[AlexSkrypnyk]

@weitzman
Thank you for looking into this.

To test your PR #5966, I've created 2 PRs:

• [#5965] Temporary updated to the master of DrupalFinder to demonstrate incompatibility. Do not merge. #5968 - to demonstrate the issue with he latest DrupalFinder - should be failing
• [#5965] Temp PR demonstrating that the fix worked with the latest version of DrupalFinder. Do not merge. #5969 - to demonstrate the latest DrupalFinder and your fix - should be passing

[AlexSkrypnyk]

Closed in #5966