Don't automatically recommend creating an issue on DefinitelyTyped #331
Conversation
…basically just be ignored
| } | ||
|
|
||
| const { repo, org } = vcsDetails | ||
| if (repo === "DefinitelyTyped" && org === "DefinitelyTyped") { |
There was a problem hiding this comment.
I wouldn't like such PR to be merge, blocking any repository. Where do we stop people suggesting blocking their repos?
The problem is solved by the community, and encouraging better collaboration, and discipline. This doesn't solve the problem properly either scales as a fix.
There was a problem hiding this comment.
Also, something super clear, I strongly agree with the underline sentiment and intent, but I strongly disagree with the proposed fix.
There was a problem hiding this comment.
I mean DT is pretty much the biggest public collection of npm packages, I'm sure it's easy to say "well DT has ~7,000 packages to cover"
There was a problem hiding this comment.
Sorry Orta, I am not sure what you are trying to coney right now, would you mind expanding on that?
|
I chatted with David about this, and it's good to go - yordis, you're welcome to read up about what definitely typed is: https://github.com/DefinitelyTyped/DefinitelyTyped but the issues this feature raises on that repo are spam and waste maintainers time |
|
This was just released in v6.5.0! Thanks for your contribution 🙏🏼 🎉 |
👋 Because the request will basically just be ignored - 1st we use Discussions for there's sorts of requests, and 2nd no-one is probably going to do the work for you because that work doesn't scale to DT size. We get one or two of these a day, might as well just not recommend them.