Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you update source-map to improve performance? #57

Closed
sunnylqm opened this issue Apr 20, 2018 · 6 comments
Closed

Can you update source-map to improve performance? #57

sunnylqm opened this issue Apr 20, 2018 · 6 comments
Assignees

Comments

@sunnylqm
Copy link

https://github.com/mozilla/source-map/blob/master/CHANGELOG.md
SourceMapConsumer now uses WebAssembly, which is much faster

@ds300
Copy link
Owner

ds300 commented Apr 21, 2018

Absolutely!

@ds300 ds300 self-assigned this Apr 21, 2018
@ds300
Copy link
Owner

ds300 commented Apr 21, 2018

I ran into an issue with this and submitted a PR to source-map to fix it mozilla/source-map#330 — will try again once that gets published.

@sunnylqm
Copy link
Author

@ds300 Appreciate your quick and nice work! FYI, the new version of source-map was published 2 days ago mozilla/source-map@b2171d5

@ds300
Copy link
Owner

ds300 commented May 19, 2018

Sweet, thanks for the heads up! I'll take a look soon.

@ds300
Copy link
Owner

ds300 commented May 23, 2018

Just published react-native-typescript-transformer@1.2.6 with the new source-map 🎉

@ds300 ds300 closed this as completed May 23, 2018
@ds300
Copy link
Owner

ds300 commented May 25, 2018

I decided to revert this change. It broke some people's builds already, and would probably break some more in the coming weeks. I don't think the perf improvements from wasm are worth the time and effort required from the people this affects. Maybe I'll try again in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants