feat: #666 - Calling Project#createSourceFile with an existing file…

… name now suggests to add the overwrite option.
dsherret · Sep 1, 2019 · 3022bb8 · 3022bb8
1 parent c929c6c
commit 3022bb8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/factories/CompilerFactory.ts b/src/factories/CompilerFactory.ts
@@ -148,7 +148,7 @@ export class CompilerFactory {
         filePath = this.context.fileSystemWrapper.getStandardizedAbsolutePath(filePath);
         if (options.overwrite === true)
             return this.createOrOverwriteSourceFileFromText(filePath, sourceText, options as MakeOptionalUndefined<typeof options>);
-        this.throwIfFileExists(filePath);
+        this.throwIfFileExists(filePath, "Did you mean to provide the overwrite option?");
         return this.createSourceFileFromTextInternal(filePath, sourceText, options as MakeOptionalUndefined<typeof options>);
     }
 

diff --git a/src/tests/projectTests.ts b/src/tests/projectTests.ts
@@ -751,7 +751,7 @@ describe(nameof(Project), () => {
             project.createSourceFile("file.ts", "");
             expect(() => {
                 project.createSourceFile("file.ts", "");
-            }).to.throw(errors.InvalidOperationError, `A source file already exists at the provided file path: /file.ts`);
+            }).to.throw(errors.InvalidOperationError, `Did you mean to provide the overwrite option? A source file already exists at the provided file path: /file.ts`);
         });
 
         it("should not throw an exception if creating a source file at an existing path when providing the overwrite option", () => {