Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle scripts #661

Closed
dsherret opened this issue Jul 9, 2019 · 3 comments
Closed

Bundle scripts #661

dsherret opened this issue Jul 9, 2019 · 3 comments
Labels
performance
Milestone
Version 4.0

Comments

@dsherret
Copy link
Owner

dsherret commented Jul 9, 2019

It really helps with start up time if all the scripts are bundled into a single js file.
@lazarljubenovic
Copy link
Contributor

Is this about bundling the distributed code of the library itself through npm? Does in-library require call really make much of a difference?

@dsherret
Copy link
Owner Author

@lazarljubenovic Yeah, I found with another library that when I packaged everything into a single file the startup time was faster (maybe that was coincidence though... and I was using a spinning disk drive...). It would at least be good to test this out and it's pretty easy to try this out with rollup.

dsherret added a commit that referenced this issue Sep 2, 2019
@dsherret
perf: #661 - Bundle scripts
6efa96d
@dsherret dsherret added this to the Version 4.0 milestone Sep 2, 2019
@dsherret
Copy link
Owner Author

dsherret commented Sep 2, 2019

Well, if anything this has reduced the package size from of the scripts from 3MB to 900KB.

@dsherret dsherret closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
Version 4.0
Development

No branches or pull requests
2 participants
@dsherret @lazarljubenovic