Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0 Proposition] Rename vorpal.catch to avoid Promise ambiguity #325

Open
AdrieanKhisbe opened this issue Oct 7, 2018 · 0 comments
Open

Comments

@AdrieanKhisbe
Copy link
Contributor

I think we should take benefit of the inbuilding v2 to rename the .catch() commands.
One of the reason is that is connote a promise method, error handling of other command.
Besides it's usage is wrongly flagged as error by the common used promised eslint config with rule promise/catch-or-return

I'm not sure on which name we should use, but something around miss like onCommandMiss, or onNonMatchingCommand, or maybe better and simplerfallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant