New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spans for elided lifetimes for references are suboptimal. #229
Comments
Good idea; thank you. Fixed in async-trait 0.1.62. |
This was done so quickly, thank you! |
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this issue
Jan 23, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [async-trait](https://github.com/dtolnay/async-trait) | dependencies | patch | `0.1.61` -> `0.1.62` | --- ### Release Notes <details> <summary>dtolnay/async-trait</summary> ### [`v0.1.62`](https://github.com/dtolnay/async-trait/releases/tag/0.1.62) [Compare Source](dtolnay/async-trait@0.1.61...0.1.62) - Improve error message involving elided lifetimes ([#​229](dtolnay/async-trait#229)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDYuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwNi4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: crapStone <crapstone01@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1746 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given how hints like
----- lifetime `'life0` defined here
below point to theasync
keyword, whereas the usage of'_
makes the span of the lifetime argument point to the'_
syntax itself, I believe it could be an improvement in UX if the span of lifetime arguments generated for&
and&mut
implicit (i.e. without “'_
”) elided lifetimes could point to the&
or the&mut
instead.the improvement should make it look more like:
The text was updated successfully, but these errors were encountered: