Delete replacement of elided lifetimes in impl heading #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently fails:
error: lifetime parameter `'impl0` only used once
--> tests/test.rs:1603:20
|
1603 | impl Trait for &Struct {
| ^
| |
| this lifetime...
| ...is used only here
|
note: the lint level is defined here
--> tests/test.rs:1591:13
|
1591 | #![deny(single_use_lifetimes)]
| ^^^^^^^^^^^^^^^^^^^^
help: elide the single-use lifetime
|
1602 ~
1603 ~ impl Trait for Struct {
|
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 6, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [async-trait](https://github.com/dtolnay/async-trait) | dependencies | patch | `0.1.64` -> `0.1.66` | --- ### Release Notes <details> <summary>dtolnay/async-trait</summary> ### [`v0.1.66`](https://github.com/dtolnay/async-trait/releases/tag/0.1.66) [Compare Source](dtolnay/async-trait@0.1.65...0.1.66) - Set html_root_url attribute ### [`v0.1.65`](https://github.com/dtolnay/async-trait/releases/tag/0.1.65) [Compare Source](dtolnay/async-trait@0.1.64...0.1.65) - Fix interaction with rustc's single_use_lifetimes lint ([#​238](dtolnay/async-trait#238), [#​239](dtolnay/async-trait#239)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuNiIsInVwZGF0ZWRJblZlciI6IjM0LjE1Ny4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: crapStone <crapstone01@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1805 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #107. The code from that PR is no longer necessary for 2 reasons.
As of Normalize projections under binders rust-lang/rust#85499 in Rust 1.56.0, the problem described in Translation of lifetimes in Fn trait input parameters #106 involving
FnOnce(&Self::ThreadPool)vsFnOnce(&<&P as ProcessPool>::ThreadPool)does not occur. These two trait bounds mean the same thing to sufficiently new versions of Rust.As of Transform blocks into
async movefor more compatibility #143 in async-trait 0.1.43 we no longer replaceFnOnce(&Self::ThreadPool)toFnOnce(&<&P as ProcessPool>::ThreadPool)in generated code, so even with old rustc, the old problem does not occur.Fixes #238.