- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 183
Conversation
i128 and u128 can now be serialized and deserialized. Support is conditionalized on the disabled-by-default `i128` feature flag, and requires rustc 1.26.0 or later. The minimum required version of Serde is now 1.0.60. Fixes dtolnay#108
Sigh, Travis seems to be skipping CI for the entire PR, not just that one commit. I'll try to fix it. |
What part of this makes it necessary to have an |
I could remove the feature. The biggest downside I see is that consumers could accidentally write code that fails to compile with older compilers. But if they're using |
Users can always accidentally write code that fails to compile with older compilers, so I would prefer not to add a Cargo feature for that reason. |
Ok, I'll remove it. BTW, the main reason I used a feature was just because bincode did. Though in bincode's case, the feature also pulls in another dependency. |
128-bit support is now automatically detected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I landed this without the changes to serde_yaml::Value. Typically for the use cases of Value either 64 bits is good enough or they actually need arbitrary precision (similar to serde_json/arbitrary_precision
).
Works for me. |
Correct. Deserializing into I published this change in 0.8.6. |
i128 and u128 can now be serialized and deserialized. Support is conditionalized on the disabled-by-default
i128
feature flag, and requires rustc 1.26.0 or later. The minimum required version of Serde is now 1.0.60.