This repository was archived by the owner on Mar 25, 2024. It is now read-only.
Add a check for strings disguised as leading zeros followed by numbers #180
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Issue #179 According to the YAML 1.2 spec (https://yaml.org/spec/1.2/spec.html#id2761292) numbers sequences with a leading zeros (that are not special encoding identifiers such as 0x, 0b, etc) are actually strings. This patch handles this case, all existing tests still pass.
dtolnay
approved these changes
Oct 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179.
According to the YAML 1.2 spec (https://yaml.org/spec/1.2/spec.html#id2761292) numbers sequences with a leading zeros (that are not special encoding identifiers such as 0x, 0b, etc) are actually strings.
This patch handles this case, all existing tests still pass.